Skip to content

Commit e58d30d

Browse files
committed
Deprecate extensions/v1beta1 deployments
1 parent b519de1 commit e58d30d

File tree

7 files changed

+45
-57
lines changed

7 files changed

+45
-57
lines changed

examples/create_deployment_from_yaml.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ def main():
2424
config.load_kube_config()
2525
k8s_client = client.ApiClient()
2626
utils.create_from_yaml(k8s_client, "nginx-deployment.yaml")
27-
k8s_api = client.ExtensionsV1beta1Api(k8s_client)
27+
k8s_api = client.AppsV1Api(k8s_client)
2828
deps = k8s_api.read_namespaced_deployment("nginx-deployment", "default")
2929
print("Deployment {0} created".format(deps.metadata.name))
3030

examples/nginx-deployment.yaml

+7-3
Original file line numberDiff line numberDiff line change
@@ -1,17 +1,21 @@
1-
apiVersion: extensions/v1beta1
1+
apiVersion: apps/v1
22
kind: Deployment
33
metadata:
44
name: nginx-deployment
5+
labels:
6+
app: nginx
57
spec:
68
replicas: 3
9+
selector:
10+
matchLabels:
11+
app: nginx
712
template:
813
metadata:
914
labels:
1015
app: nginx
1116
spec:
1217
containers:
1318
- name: nginx
14-
image: nginx:1.7.9
19+
image: nginx:1.15.4
1520
ports:
1621
- containerPort: 80
17-

kubernetes/e2e_test/test_utils.py

+12-25
Original file line numberDiff line numberDiff line change
@@ -52,21 +52,6 @@ def test_create_apps_deployment_from_yaml(self):
5252
name="nginx-app", namespace="default",
5353
body={})
5454

55-
def test_create_extensions_deployment_from_yaml(self):
56-
"""
57-
Should be able to create an extensions/v1beta1 deployment.
58-
"""
59-
k8s_client = client.api_client.ApiClient(configuration=self.config)
60-
utils.create_from_yaml(
61-
k8s_client, self.path_prefix + "extensions-deployment.yaml")
62-
ext_api = client.ExtensionsV1beta1Api(k8s_client)
63-
dep = ext_api.read_namespaced_deployment(name="nginx-deployment",
64-
namespace="default")
65-
self.assertIsNotNone(dep)
66-
ext_api.delete_namespaced_deployment(
67-
name="nginx-deployment", namespace="default",
68-
body={})
69-
7055
def test_create_pod_from_yaml(self):
7156
"""
7257
Should be able to create a pod.
@@ -134,7 +119,7 @@ def test_create_deployment_non_default_namespace_from_yaml(self):
134119
utils.create_from_yaml(
135120
k8s_client, self.path_prefix + "dep-deployment.yaml")
136121
core_api = client.CoreV1Api(k8s_client)
137-
ext_api = client.ExtensionsV1beta1Api(k8s_client)
122+
ext_api = client.AppsV1Api(k8s_client)
138123
nmsp = core_api.read_namespace(name="dep")
139124
self.assertIsNotNone(nmsp)
140125
dep = ext_api.read_namespaced_deployment(name="nginx-deployment",
@@ -186,7 +171,7 @@ def test_create_general_list_from_yaml(self):
186171
utils.create_from_yaml(
187172
k8s_client, self.path_prefix + "list.yaml")
188173
core_api = client.CoreV1Api(k8s_client)
189-
ext_api = client.ExtensionsV1beta1Api(k8s_client)
174+
ext_api = client.AppsV1Api(k8s_client)
190175
svc = core_api.read_namespaced_service(name="list-service-test",
191176
namespace="default")
192177
self.assertIsNotNone(svc)
@@ -317,7 +302,7 @@ def test_create_from_multi_resource_yaml_with_conflict(self):
317302

318303
def test_create_from_multi_resource_yaml_with_multi_conflicts(self):
319304
"""
320-
Should create an extensions/v1beta1 deployment
305+
Should create an apps/v1 deployment
321306
and fail to create the same deployment twice.
322307
Should raise an exception that contains two error messages.
323308
"""
@@ -327,14 +312,14 @@ def test_create_from_multi_resource_yaml_with_multi_conflicts(self):
327312
k8s_client, self.path_prefix + "triple-nginx.yaml")
328313
exp_error = ('Error from server (Conflict): {"kind":"Status",'
329314
'"apiVersion":"v1","metadata":{},"status":"Failure",'
330-
'"message":"deployments.extensions \\"triple-nginx\\" '
315+
'"message":"deployments.apps \\"triple-nginx\\" '
331316
'already exists","reason":"AlreadyExists",'
332-
'"details":{"name":"triple-nginx","group":"extensions",'
317+
'"details":{"name":"triple-nginx","group":"apps",'
333318
'"kind":"deployments"},"code":409}\n'
334319
)
335320
exp_error += exp_error
336321
self.assertEqual(exp_error, str(cm.exception))
337-
ext_api = client.ExtensionsV1beta1Api(k8s_client)
322+
ext_api = client.AppsV1Api(k8s_client)
338323
dep = ext_api.read_namespaced_deployment(name="triple-nginx",
339324
namespace="default")
340325
self.assertIsNotNone(dep)
@@ -348,7 +333,8 @@ def test_create_namespaces_apps_deployment_from_yaml(self):
348333
"""
349334
k8s_client = client.api_client.ApiClient(configuration=self.config)
350335
utils.create_from_yaml(
351-
k8s_client, self.path_prefix + "apps-deployment.yaml", namespace=self.test_namespace)
336+
k8s_client, self.path_prefix + "apps-deployment.yaml",
337+
namespace=self.test_namespace)
352338
app_api = client.AppsV1beta1Api(k8s_client)
353339
dep = app_api.read_namespaced_deployment(name="nginx-app",
354340
namespace=self.test_namespace)
@@ -357,14 +343,15 @@ def test_create_namespaces_apps_deployment_from_yaml(self):
357343
name="nginx-app", namespace=self.test_namespace,
358344
body={})
359345

360-
def test_create_from_list_in_multi_resource_yaml(self):
346+
def test_create_from_list_in_multi_resource_yaml_namespaced(self):
361347
"""
362348
Should be able to create the items in the PodList and a deployment
363-
specified in the multi-resource file
349+
specified in the multi-resource file in a test namespace
364350
"""
365351
k8s_client = client.api_client.ApiClient(configuration=self.config)
366352
utils.create_from_yaml(
367-
k8s_client, self.path_prefix + "multi-resource-with-list.yaml", namespace=self.test_namespace)
353+
k8s_client, self.path_prefix + "multi-resource-with-list.yaml",
354+
namespace=self.test_namespace)
368355
core_api = client.CoreV1Api(k8s_client)
369356
app_api = client.AppsV1beta1Api(k8s_client)
370357
pod_0 = core_api.read_namespaced_pod(

kubernetes/e2e_test/test_yaml/dep-deployment.yaml

+5-3
Original file line numberDiff line numberDiff line change
@@ -1,18 +1,20 @@
1-
apiVersion: extensions/v1beta1
1+
apiVersion: apps/v1
22
kind: Deployment
33
metadata:
44
name: nginx-deployment
55
namespace: dep
66
spec:
77
replicas: 3
8+
selector:
9+
matchLabels:
10+
app: nginx
811
template:
912
metadata:
1013
labels:
1114
app: nginx
1215
spec:
1316
containers:
1417
- name: nginx
15-
image: nginx:1.7.9
18+
image: nginx:1.15.4
1619
ports:
1720
- containerPort: 80
18-

kubernetes/e2e_test/test_yaml/extensions-deployment.yaml

-17
This file was deleted.

kubernetes/e2e_test/test_yaml/list.yaml

+5-2
Original file line numberDiff line numberDiff line change
@@ -11,19 +11,22 @@ items:
1111
port: 80
1212
selector:
1313
app: list-deployment-test
14-
- apiVersion: extensions/v1beta1
14+
- apiVersion: apps/v1
1515
kind: Deployment
1616
metadata:
1717
name: list-deployment-test
1818
labels:
1919
app: list-deployment-test
2020
spec:
2121
replicas: 1
22+
selector:
23+
matchLabels:
24+
app: list-deployment-test
2225
template:
2326
metadata:
2427
labels:
2528
app: list-deployment-test
2629
spec:
2730
containers:
2831
- name: nginx
29-
image: nginx
32+
image: nginx:1.15.4
Original file line numberDiff line numberDiff line change
@@ -1,50 +1,59 @@
1-
apiVersion: extensions/v1beta1
1+
apiVersion: apps/v1
22
kind: Deployment
33
metadata:
44
name: triple-nginx
55
spec:
66
replicas: 3
7+
selector:
8+
matchLabels:
9+
app: nginx
710
template:
811
metadata:
912
labels:
1013
app: nginx
1114
spec:
1215
containers:
1316
- name: nginx
14-
image: nginx:1.7.9
17+
image: nginx:1.15.4
1518
ports:
1619
- containerPort: 80
1720
---
18-
apiVersion: extensions/v1beta1
21+
apiVersion: apps/v1
1922
kind: Deployment
2023
metadata:
2124
name: triple-nginx
2225
spec:
2326
replicas: 3
27+
selector:
28+
matchLabels:
29+
app: nginx
2430
template:
2531
metadata:
2632
labels:
2733
app: nginx
2834
spec:
2935
containers:
3036
- name: nginx
31-
image: nginx:1.7.9
37+
image: nginx:1.15.4
3238
ports:
3339
- containerPort: 80
3440
---
35-
apiVersion: extensions/v1beta1
41+
apiVersion: apps/v1
3642
kind: Deployment
3743
metadata:
3844
name: triple-nginx
3945
spec:
4046
replicas: 3
47+
selector:
48+
matchLabels:
49+
app: nginx
4150
template:
4251
metadata:
4352
labels:
4453
app: nginx
4554
spec:
4655
containers:
4756
- name: nginx
48-
image: nginx:1.7.9
57+
image: nginx:1.15.4
4958
ports:
5059
- containerPort: 80

0 commit comments

Comments
 (0)