Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sweep and adjust filesystem Stat/Lstat/EvalSymlinks calls in go 1.23 #361

Open
mauriciopoppe opened this issue Dec 5, 2024 · 2 comments
Labels
lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness.

Comments

@mauriciopoppe
Copy link
Member

mauriciopoppe commented Dec 5, 2024

Context: kubernetes/kubernetes#129084

Go 1.23 changed stdlib behavior of filesystem calls Stat / Lstat / EvalSymlinks on Windows. This broke some kubelet handling of volumes on Windows, and possibly other use of those functions. For Kubernetes 1.32, the behavior was temporarily reverted via godebug switches in kubernetes/kubernetes#129083, but this is not a long-term solution. Libraries like k8s.io/mount-utils can be used by downstream consumers building with go 1.23 and get unintented behavior.

Even though this project hasn't been updated to use go 1.23 (still using go 1.20), it's possible that the project is built from source using a different go runtime. If the project is built with go 1.23+

Also read kubernetes/kubernetes#129103

@mauriciopoppe
Copy link
Member Author

/lifecycle frozen

@k8s-ci-robot k8s-ci-robot added the lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. label Dec 5, 2024
@liggitt
Copy link

liggitt commented Dec 6, 2024

note that we may just be setting the winsymlink option, see discussion in kubernetes/kubernetes#129103

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness.
Projects
None yet
Development

No branches or pull requests

3 participants