Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Precision about failedPrecondition as final error #604

Open
guilhem opened this issue Nov 26, 2024 · 1 comment
Open

Precision about failedPrecondition as final error #604

guilhem opened this issue Nov 26, 2024 · 1 comment

Comments

@guilhem
Copy link

guilhem commented Nov 26, 2024

Following #53 and #54

According to CSI spec, a volume published to another node should report FAILED_PRECONDITION even if change is underway.
https://github.com/container-storage-interface/spec/blob/98819c45a37a67e0cd466bd02b813faf91af4e45/spec.md?plain=1#L1384

external-attacher will consider it as a final error, is it the behavior we want?

@jsafrane
Copy link
Contributor

jsafrane commented Dec 3, 2024

I'm not sure I understand the concern. My interpretation of FAILED_PRECONDITION returned to ControllerPublishRequest with {"node_id": "node_A"} means that the volume cannot be being attached to node_A, because it's attached to another node. And thus we can consider it final.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants