Improve PVC condition message for ModifyVolume failing with infeasible errors.

grant-he · grant-he · commit c3eba1bf7ff5 · 2025-08-14T22:01:04.000Z
diff --git a/pkg/modifycontroller/modify_status.go b/pkg/modifycontroller/modify_status.go
@@ -48,7 +48,7 @@ func (ctrl *modifyController) markControllerModifyVolumeStatus(
 	case v1.PersistentVolumeClaimModifyVolumeInProgress:
 		conditionMessage = "ModifyVolume operation in progress."
 	case v1.PersistentVolumeClaimModifyVolumeInfeasible:
-		conditionMessage = "ModifyVolume failed with error" + err.Error() + ". Waiting for retry."
+		conditionMessage = "ModifyVolume failed with error: " + err.Error() + ". Waiting for retry."
 	}
 	pvcCondition.Message = conditionMessage
 	// Do not change conditions for pending modifications and keep existing conditions
diff --git a/pkg/modifycontroller/modify_status_test.go b/pkg/modifycontroller/modify_status_test.go
@@ -46,7 +46,7 @@ var (
 	pvcConditionInfeasible = v1.PersistentVolumeClaimCondition{
 		Type:    v1.PersistentVolumeClaimVolumeModifyingVolume,
 		Status:  v1.ConditionTrue,
-		Message: "ModifyVolume failed with errorrpc error: code = InvalidArgument desc = Parameters in VolumeAttributesClass is invalid. Waiting for retry.",
+		Message: "ModifyVolume failed with error: rpc error: code = InvalidArgument desc = Parameters in VolumeAttributesClass is invalid. Waiting for retry.",
 	}
 
 	pvcConditionError = v1.PersistentVolumeClaimCondition{

Original file line number	Diff line number	Diff line change
`@@ -48,7 +48,7 @@ func (ctrl *modifyController) markControllerModifyVolumeStatus(`
`48`	`48`	`case v1.PersistentVolumeClaimModifyVolumeInProgress:`
`49`	`49`	`conditionMessage = "ModifyVolume operation in progress."`
`50`	`50`	`case v1.PersistentVolumeClaimModifyVolumeInfeasible:`
`51`		`- conditionMessage = "ModifyVolume failed with error" + err.Error() + ". Waiting for retry."`
	`51`	`+ conditionMessage = "ModifyVolume failed with error: " + err.Error() + ". Waiting for retry."`
`52`	`52`	`}`
`53`	`53`	`pvcCondition.Message = conditionMessage`
`54`	`54`	`// Do not change conditions for pending modifications and keep existing conditions`
Original file line number	Diff line number	Diff line change
`@@ -46,7 +46,7 @@ var (`
`46`	`46`	`pvcConditionInfeasible = v1.PersistentVolumeClaimCondition{`
`47`	`47`	`Type: v1.PersistentVolumeClaimVolumeModifyingVolume,`
`48`	`48`	`Status: v1.ConditionTrue,`
`49`		`- Message: "ModifyVolume failed with errorrpc error: code = InvalidArgument desc = Parameters in VolumeAttributesClass is invalid. Waiting for retry.",`
	`49`	`+ Message: "ModifyVolume failed with error: rpc error: code = InvalidArgument desc = Parameters in VolumeAttributesClass is invalid. Waiting for retry.",`
`50`	`50`	`}`
`51`	`51`
`52`	`52`	`pvcConditionError = v1.PersistentVolumeClaimCondition{`