VolumesnapshotContent RestoreSize is set to 0 for the snapshots created for volumesnapshotgroup

[Madhu-1]

What happened:

The RestoreSize of each volumesnapshotcontent is set to 0 even though CSI responds back the size the VolumeGroupSnapshostCreate Response, This might be because the snapshotter create the VSC with empty status and its also reconciling the VSC and Doing GetVolumeSnapshot and updating the size

external-snapshotter/pkg/sidecar-controller/snapshot_controller.go

Lines 282 to 296 in 533a2ee

	readyToUse, creationTime, size, groupSnapshotID, err = ctrl.handler.GetSnapshotStatus(content, snapshotterListCredentials)
	if err != nil {
	klog.Errorf("checkandUpdateContentStatusOperation: failed to call get snapshot status to check whether snapshot is ready to use %q", err)
	return content, err
	}
	driverName = content.Spec.Driver
	snapshotID = *content.Spec.Source.SnapshotHandle
	klog.V(5).Infof("checkandUpdateContentStatusOperation: driver %s, snapshotId %s, creationTime %v, size %d, readyToUse %t, groupSnapshotID %s", driverName, snapshotID, creationTime, size, readyToUse, groupSnapshotID)
	if creationTime.IsZero() {
	creationTime = time.Now()
	}
	updatedContent, err := ctrl.updateSnapshotContentStatus(content, snapshotID, readyToUse, creationTime.UnixNano(), size, groupSnapshotID)

Not all CSI drivers implement ListSnapshots as it's not a mandatory RPC call.

What you expected to happen:

How to reproduce it:
The RestoreSize of each volumesnapshotcontent is set to the actual size returned in VolumeGroupSnapshostCreate Response

Anything else we need to know?:

Environment:

• Driver version: 7.0.0
• Kubernetes version (use kubectl version):
• OS (e.g. from /etc/os-release):
• Kernel (e.g. uname -a):
• Install tools:
• Others:

[Madhu-1]

@xing-yang is this something that we can fix? i tried to fix it Madhu-1@9382f1a this way i am not sure if this is the correct approach or not, if yes i can make a PR from it.

[Madhu-1]

cc @nixpanic

[nixpanic]

Calling the ListSnapshots CSI procedure should not be required. The RestoreSize of each snapshot is returned as part of the reply to the CreateGroupSnapshot CSI procedure (see repeated Snapshot snapshots = 2 in the spec).

[Madhu-1]

@nixpanic sent #1011 to fix it, PTAL