Skip to content
This repository has been archived by the owner on Oct 28, 2024. It is now read-only.

Confuse with capi provisioner's manifest file #143

Closed
vincent-pli opened this issue Jun 19, 2021 · 3 comments
Closed

Confuse with capi provisioner's manifest file #143

vincent-pli opened this issue Jun 19, 2021 · 3 comments
Labels
kind/bug Categorizes issue or PR as related to a bug.

Comments

@vincent-pli
Copy link
Contributor

What steps did you take and what happened:
[A clear and concise description on how to REPRODUCE the bug.]
I'm little, seems we try to add capi provisioner and remove native and aliyun.

But I found we change some field in the original manifest file, for example:

  • Change pullpolicy to Never

https://github.com/kubernetes-sigs/cluster-api-provider-nested/blob/ce11f3e9a73dbf2d691a4d06c5ef2d5b908620a7/virtualcluster/config/setup/all_in_one_capi.yaml#L246

https://github.com/kubernetes-sigs/cluster-api-provider-nested/blob/ce11f3e9a73dbf2d691a4d06c5ef2d5b908620a7/virtualcluster/config/setup/all_in_one_capi.yaml#L386

https://github.com/kubernetes-sigs/cluster-api-provider-nested/blob/ce11f3e9a73dbf2d691a4d06c5ef2d5b908620a7/virtualcluster/config/setup/all_in_one_capi.yaml#L470

Would you mind I change it back?

What did you expect to happen:

Anything else you would like to add:
[Miscellaneous information that will assist in solving the issue.]

Environment:

  • cluster-api-provider-nested version:
  • Minikube/KIND version:
  • Kubernetes version: (use kubectl version):
  • OS (e.g. from /etc/os-release):

/kind bug
[One or more /area label. See https://github.com/kubernetes-sigs/cluster-api-provider-nested/labels?q=area for the list of labels]

@k8s-ci-robot k8s-ci-robot added the kind/bug Categorizes issue or PR as related to a bug. label Jun 19, 2021
@christopherhein
Copy link
Contributor

These changes need to migrated to support the CAPI style deployment manifest generation as we have in the base repo. This work is being tracked under #129 .

@christopherhein
Copy link
Contributor

/close

@k8s-ci-robot
Copy link
Contributor

@christopherhein: Closing this issue.

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
kind/bug Categorizes issue or PR as related to a bug.
Projects
None yet
Development

No branches or pull requests

3 participants