Adding unittests

Author: mukhoakash

container-object-storage-interface-provisioner-sidecar/pkg/bucket/bucket_controller.go

@@ -145,7 +145,7 @@ func (b *BucketListener) Add(ctx context.Context, inputBucket *v1alpha1.Bucket)
 		} else {
 			klog.V(3).ErrorS(err, "DriverCreateBucket returned an empty bucketID",
 				"bucket", bucket.ObjectMeta.Name)
-			err = errors.New(fmt.Sprintf("DriverCreateBucket returned an empty bucketID for bucket: %s",bucket.ObjectMeta.Name))
+			err = errors.New(fmt.Sprintf("DriverCreateBucket returned an empty bucketID for bucket: %s", bucket.ObjectMeta.Name))
 			return err
 		}
 

container-object-storage-interface-provisioner-sidecar/pkg/bucket/bucket_controller_test.go

@@ -17,6 +17,7 @@ package bucket
 
 import (
 	"context"
+	"errors"
 	"reflect"
 	"testing"
 
@@ -25,6 +26,7 @@ import (
 	cosi "sigs.k8s.io/container-object-storage-interface-spec"
 	fakespec "sigs.k8s.io/container-object-storage-interface-spec/fake"
 
+	metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
 	utilversion "k8s.io/apimachinery/pkg/util/version"
 	"k8s.io/apimachinery/pkg/version"
 	fakediscovery "k8s.io/client-go/discovery/fake"
@@ -86,7 +88,8 @@ func TestAddWrongProvisioner(t *testing.T) {
 
 	b := v1alpha1.Bucket{
 		Spec: v1alpha1.BucketSpec{
-			DriverName: "driver2",
+			DriverName:      "driver2",
+			BucketClassName: "test-bucket",
 		},
 	}
 	ctx := context.TODO()
@@ -95,3 +98,34 @@ func TestAddWrongProvisioner(t *testing.T) {
 		t.Errorf("Error returned: %+v", err)
 	}
 }
+
+func TestMissingBucketClassName(t *testing.T) {
+	driver := "driver1"
+	mpc := struct{ fakespec.FakeProvisionerClient }{}
+	mpc.FakeDriverCreateBucket = func(ctx context.Context,
+		in *cosi.DriverCreateBucketRequest,
+		opts ...grpc.CallOption) (*cosi.DriverCreateBucketResponse, error) {
+		t.Errorf("grpc client called")
+		return nil, nil
+	}
+
+	bl := BucketListener{
+		driverName:        driver,
+		provisionerClient: &mpc,
+	}
+
+	b := v1alpha1.Bucket{
+		ObjectMeta: metav1.ObjectMeta{
+			Name: "testbucket",
+		},
+		Spec: v1alpha1.BucketSpec{
+			DriverName: "driver1",
+		},
+	}
+	ctx := context.TODO()
+	err := bl.Add(ctx, &b)
+	expectedErr := errors.New("BucketClassName not defined for bucket testbucket")
+	if err == nil || err.Error() != expectedErr.Error() {
+		t.Errorf("Expecter error: %+v \n Returned error: %+v", expectedErr, err)
+	}
+}