etcdadm scripts should be written to files at render phase, not up

[redbaron]

right now etcdadm script is embedded in kube-aws binary and "materializes" itself only when we run "kube-aws up/update" which makes it harder to track full kluster config in git

[mumoshu]

@redbaron Thanks for the feedback 👍
Yes, it should be. It was even in the "remaining issues" list in the original PR which introduced etcdadm.

How about scripts/ directory to store scripts like etcdadm?
Any preference on the naming of the directory?

[redbaron]

why scripts is everything else is in write_files?

[mumoshu]

@redbaron My intention was to ensure users place only scripts inside the directory. The same as credentials for /etc/kubernetes/ssl.

Would you like to embed etcdadm directly into cloud-config-etcd like:

  - path: /opt/bin/etcdadm
    content: |
      // the content of etcdadm here

or anything else?

[redbaron]

either way works for me. scripts is more convenient, but probably would require more work

[fejta-bot]

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

[fejta-bot]

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle rotten

[fejta-bot]

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close

[k8s-ci-robot]

@fejta-bot: Closing this issue.

In response to this:

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.