Skip to content
This repository has been archived by the owner on May 25, 2023. It is now read-only.

Delay Pod creation #539

Closed
k82cn opened this issue Jan 5, 2019 · 11 comments
Closed

Delay Pod creation #539

k82cn opened this issue Jan 5, 2019 · 11 comments
Labels
kind/feature Categorizes issue or PR as related to a new feature. lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. sig/apps Categorizes an issue or PR as relevant to SIG Apps. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling.
Milestone
v0.5

Comments

@k82cn
Copy link
Contributor

k82cn commented Jan 5, 2019 •
edited
Loading

Is this a BUG REPORT or FEATURE REQUEST?:

/kind feature

Description:

For batch workload, there're always several pending jobs in the system because of limited resource. If pods were created for each job, there'll be so many pending pods :(

It's better to let kube-batch notify controller whether the pod should be created according to quota and resources.
@k8s-ci-robot k8s-ci-robot added the kind/feature Categorizes issue or PR as related to a new feature. label Jan 5, 2019
@k82cn
Copy link
Contributor Author

k82cn commented Jan 5, 2019

xref #401

@k82cn k82cn added this to the v0.4 milestone Jan 5, 2019
@k82cn k82cn added priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. labels Jan 5, 2019
@k82cn
Copy link
Contributor Author

k82cn commented Jan 7, 2019

/cc @jlewi

@jiaxuanzhou jiaxuanzhou mentioned this issue Jan 7, 2019
Merged
@k82cn k82cn mentioned this issue Jan 9, 2019
Merged
@k82cn k82cn modified the milestones: v0.4, v0.5 Jan 15, 2019
@k82cn k82cn mentioned this issue Mar 16, 2019
Closed
@hex108
Copy link
Contributor

hex108 commented Mar 26, 2019

@k82cn Could we implement it using admission webhook?

@k82cn
Copy link
Contributor Author

k82cn commented Mar 26, 2019 •
edited
Loading

implement it using admission webhook

admission webhook did not know other info except current pod, which lose the context; IMO, it's better to let scheduler to decide which PodGroup can create more pods.

@hex108
Copy link
Contributor

hex108 commented Mar 26, 2019

As I understand, admission webhook could list/get/.. all resources.

it's better to let scheduler to decide which PodGroup can create more pods.

Then we need modify controllers?

@k82cn
Copy link
Contributor Author

k82cn commented Mar 30, 2019

Then we need modify controllers?

It's up to the contoller whehter leverage this feature.

@k82cn
Copy link
Contributor Author

k82cn commented Apr 22, 2019

/sig apps

@k8s-ci-robot k8s-ci-robot added the sig/apps Categorizes an issue or PR as relevant to SIG Apps. label Apr 22, 2019
@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jul 21, 2019
@fejta-bot
Copy link

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle rotten

@k8s-ci-robot k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Aug 20, 2019
@fejta-bot
Copy link

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close

@k8s-ci-robot
Copy link
Contributor

@fejta-bot: Closing this issue.

In response to this:

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
kind/feature Categorizes issue or PR as related to a new feature. lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. sig/apps Categorizes an issue or PR as relevant to SIG Apps. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling.
Projects
None yet
Milestone
v0.5
Development

No branches or pull requests
4 participants
@hex108 @k82cn @k8s-ci-robot @fejta-bot