Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ability to add provider specific featureGates with Helm #447

Closed
oprinmarius opened this issue Mar 6, 2024 · 1 comment · Fixed by #448
Closed

Ability to add provider specific featureGates with Helm #447

oprinmarius opened this issue Mar 6, 2024 · 1 comment · Fixed by #448
Labels
kind/feature Categorizes issue or PR as related to a new feature. triage/accepted Indicates an issue or PR is ready to be actively worked on.

Comments

@oprinmarius
Copy link
Member

User Story

As a operator I would like to have the ability to add provider specific featureGates.

Detailed Description
Currently manager featureGates are only added to the InfrastructureProvider.
There is no option to add featureGates to CoreProvider (eg. MachinePool)
Adding all featureGates to CoreProvider will often break the deployment because of provider specific featureGates that are not compatible with the CoreProvider (eg. EKSEnableIAM ).

Example:

  • Add support for provider specific featureGates
    6c9e585

  • Add featureGates to CoreProvider
    fa051d4

values.yaml:

manager:
  featureGates:
    core:
      ClusterTopology: true
      MachinePool: true
    aws:
      EKSEnableIAM: true
      EKSAllowAddRoles: true
      ClusterTopology: true
      MachinePool: true

/kind feature

@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Mar 6, 2024
@oprinmarius oprinmarius changed the title Ability to add provider specific featureGates Ability to add provider specific featureGates with Helm Mar 6, 2024
@alexander-demicev
Copy link
Contributor

/triage accepted

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants