Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement MachinePool Machines clusterAPI proposal #4184

Open
cnmcavoy opened this issue Mar 30, 2023 · 10 comments · May be fixed by #5174
Open

Implement MachinePool Machines clusterAPI proposal #4184

cnmcavoy opened this issue Mar 30, 2023 · 10 comments · May be fixed by #5174
Assignees
@AndiDog
Labels
kind/feature Categorizes issue or PR as related to a new feature. lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. triage/accepted Indicates an issue or PR is ready to be actively worked on.

Comments

@cnmcavoy
Copy link
Contributor

cnmcavoy commented Mar 30, 2023 •
edited
Loading

/kind feature

Describe the solution you'd like
Provide an implementation for MachinePool Machines based off of this proposal.

AWSMachinePools & AWSManagedMachinePools should implement a status field for infrastructureMachineKind and infrastructureMachineSelector and manage these status fields in the controller reconcile loop. Each controller should spawn AWSMachine resources to represent EC2 instances managed by their external AWS autoscaling group resource. These AWSMachines need to have special handling in the AWSMachine reconciliation to skip any unnecessary steps for externally managed nodes.

Anything else you would like to add:
See the clusterAPI implementation of their part of the proposal here: kubernetes-sigs/cluster-api#7938
@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. needs-priority needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Mar 30, 2023
@cnmcavoy
Copy link
Contributor Author

/assign @cnmcavoy

@richardcase richardcase mentioned this issue Apr 3, 2023
Open
@cnmcavoy cnmcavoy mentioned this issue May 2, 2023
Closed
4 tasks
@com6056
Copy link

com6056 commented May 9, 2023 •
edited
Loading

Do we think it is worth updating the docs in https://cluster-api-aws.sigs.k8s.io/topics/machinepools.html#autoscaling to reflect that in it's current state, you can't use the cluster-autoscaler clusterapi provider to scale MachinePools? It looks like this feature is required to be able to scale down properly.

@com6056 com6056 mentioned this issue Jun 26, 2023
Closed
@richardcase
Copy link
Member

/milestone v2.3.0
/triage accepted
/priority important-soon

@k8s-ci-robot k8s-ci-robot added this to the v2.3.0 milestone Aug 16, 2023
@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority labels Aug 16, 2023
@cnmcavoy cnmcavoy mentioned this issue Sep 27, 2023
Closed
4 tasks
@richardcase richardcase modified the milestones: v2.3.0, v2.4.0 Oct 16, 2023
@AndiDog AndiDog mentioned this issue Nov 22, 2023
Open
2 tasks
@k8s-triage-robot
Copy link

This issue is labeled with priority/important-soon but has not been updated in over 90 days, and should be re-triaged.
Important-soon issues must be staffed and worked on either currently, or very soon, ideally in time for the next release.

You can:

  • Confirm that this issue is still relevant with /triage accepted (org members only)
  • Deprioritize it with /priority important-longterm or /priority backlog
  • Close this issue with /close

For more details on the triage process, see https://www.kubernetes.dev/docs/guide/issue-triage/

/remove-triage accepted

@k8s-ci-robot k8s-ci-robot added needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. and removed triage/accepted Indicates an issue or PR is ready to be actively worked on. labels Jan 19, 2024
@richardcase
Copy link
Member

/milestone clear

@k8s-ci-robot k8s-ci-robot removed this from the v2.4.0 milestone Jan 23, 2024
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue as fresh with /remove-lifecycle stale
  • Close this issue with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Apr 22, 2024
@richardcase
Copy link
Member

/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Apr 22, 2024
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue as fresh with /remove-lifecycle stale
  • Close this issue with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jul 21, 2024
@richardcase
Copy link
Member

/remove-lifecycle stale
/lifecycle frozen

@k8s-ci-robot k8s-ci-robot added lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Jul 24, 2024
@cnmcavoy cnmcavoy removed their assignment Aug 27, 2024
@AndiDog
Copy link
Contributor

AndiDog commented Oct 22, 2024

/assign
/triage accepted

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Oct 22, 2024
@AndiDog AndiDog linked a pull request Oct 22, 2024 that will close this issue
Open
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AndiDog AndiDog

Labels
kind/feature Categorizes issue or PR as related to a new feature. lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
No milestone
6 participants
@richardcase @AndiDog @com6056 @cnmcavoy @k8s-ci-robot @k8s-triage-robot