Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Need to set ProviderID on common Machine objects #610

Closed
detiber opened this issue Feb 25, 2019 · 7 comments · Fixed by #637
Closed

Need to set ProviderID on common Machine objects #610

detiber opened this issue Feb 25, 2019 · 7 comments · Fixed by #637
Assignees
@detiber
Labels
kind/bug Categorizes issue or PR as related to a bug. lifecycle/active Indicates that an issue or PR is actively being worked on by a contributor. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete.
Milestone
v1alpha1

Comments

@detiber
Copy link
Member

detiber commented Feb 25, 2019

/kind bug

What steps did you take and what happened:
Deploy a machine using cluster-api-provider-aws, the machine Spec.ProviderID field will be empty

What did you expect to happen:
The Spec.ProviderID field should be set with a string in the same format as is populated by Spec.ProviderID on a Node object.

/priority important-longterm
/milestone v1alpha1
@k8s-ci-robot k8s-ci-robot added this to the v1alpha1 milestone Feb 25, 2019
@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. labels Feb 25, 2019
@vincepri
Copy link
Member

@detiber Do you have an example for the string format?

@detiber
Copy link
Member Author

detiber commented Feb 25, 2019

https://github.com/kubernetes/kubernetes/blob/30ed3b41b7b080cf37639371726a445032d5ef29/pkg/cloudprovider/providers/aws/instances.go#L48-L53

@vincepri
Copy link
Member

Could we copy the ProviderID from the Node object now that we're setting the reference?

@detiber
Copy link
Member Author

detiber commented Feb 25, 2019

@vincepri as long as we can query Node objects that belong to a remote k8s cluster, since the management cluster may not be local.

@ncdc
Copy link
Contributor

ncdc commented Feb 28, 2019

Depends on kubernetes-sigs/cluster-api#520

@ncdc
Copy link
Contributor

ncdc commented Feb 28, 2019

We could consider bumping this to Next if it comes down to the wire - we don't lose any functionality if the data is not populated.

@detiber
Copy link
Member Author

detiber commented Mar 8, 2019

/assign
/lifecycle active

@k8s-ci-robot k8s-ci-robot added the lifecycle/active Indicates that an issue or PR is actively being worked on by a contributor. label Mar 8, 2019
@detiber detiber mentioned this issue Mar 8, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@detiber detiber

Labels
kind/bug Categorizes issue or PR as related to a bug. lifecycle/active Indicates that an issue or PR is actively being worked on by a contributor. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete.
Projects
None yet
Milestone
v1alpha1
Development

Successfully merging a pull request may close this issue.

Set the ProviderID if unset detiber/cluster-api-provider-aws
4 participants
@ncdc @detiber @vincepri @k8s-ci-robot