-
Notifications
You must be signed in to change notification settings - Fork 425
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Machine deployment scale fails after v1alpha3 -> v1alpha4,v1beta1 upgrade #1770
Labels
kind/bug
Categorizes issue or PR as related to a bug.
priority/important-soon
Must be staffed and worked on either currently, or very soon, ideally in time for the next release.
Comments
/priority important-soon |
k8s-ci-robot
added
the
priority/important-soon
Must be staffed and worked on either currently, or very soon, ideally in time for the next release.
label
Oct 11, 2021
I verified this by printing old and new specs in validation webhooks:
|
3 tasks
Thanks for catching this @shysank. Looking forward to having CI tests for this. |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
kind/bug
Categorizes issue or PR as related to a bug.
priority/important-soon
Must be staffed and worked on either currently, or very soon, ideally in time for the next release.
/kind bug
What steps did you take and what happened:
AzureMachineTemplate
What did you expect to happen:
machine deployment should scale to 2
Anything else you would like to add:
This is because we added new default webhooks in azure machine template which were not there in v1alpha3. When capi tries to update owner references for infrastructure reference (azuremachinetemplate), it applies the default webhooks, specifically, it sets
osdisk.CachingType = None
, but the default webhooks are not applied for the old spec. So,validateUpdate
fails because we check for immutability.Environment:
kubectl version
):/etc/os-release
):The text was updated successfully, but these errors were encountered: