-
Notifications
You must be signed in to change notification settings - Fork 261
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add tags to security groups when ManagedSecurityGroups: true #1044
Comments
This sounds like a good feature to me. I don't feel like we should propagate tags to cluster status. Additionally I wonder if, in general, we should update tags on existing resources. We don't modify the resources themselves after creation, but tags are metadata. Does this immutability include tags? The ability to change tags on existing resources seems useful both to us as developers: to fix a bug at resource creation time, and to users: to change the way resources are identified in a cloud after creation. |
+1 to include tags to the resource created by CAPO
so your suggestion is to allow the update of |
This does indeed sound like a nice addition. I'd say though that it possibly exceeds tags on SGs, at least all tagged resources, and possibly other configs that can be updated and seem reasonable to be changed as day2 operations. I think this should be tackled in a separate issue though. For the time being, I opened a PR just adding tags on SGs |
/kind feature
Describe the solution you'd like
Security groups created when
ManagedSecurityGroups: true
should be tagged when Tags are defined onOpenStackCluster
similarly to how network/subnet/router etc are being taggedAnything else you would like to add:
openStackCluster.Status
similarly to how it's done for network/subnet/router? (it's not done the floatingIp of the loadbalancer but i think that's a bit of a different use case)The text was updated successfully, but these errors were encountered: