Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tags to security groups when ManagedSecurityGroups: true #1044

Closed
nikParasyr opened this issue Nov 12, 2021 · 3 comments · Fixed by #1053
Closed

Add tags to security groups when ManagedSecurityGroups: true #1044

nikParasyr opened this issue Nov 12, 2021 · 3 comments · Fixed by #1053
Labels
kind/feature Categorizes issue or PR as related to a new feature.

Comments

@nikParasyr
Copy link
Contributor

/kind feature

Describe the solution you'd like
Security groups created when ManagedSecurityGroups: true should be tagged when Tags are defined on OpenStackCluster similarly to how network/subnet/router etc are being tagged

Anything else you would like to add:

  • i'd like to work on this one
  • Question: Should the tags be propagated to openStackCluster.Status similarly to how it's done for network/subnet/router? (it's not done the floatingIp of the loadbalancer but i think that's a bit of a different use case)
@k8s-ci-robot k8s-ci-robot added the kind/feature Categorizes issue or PR as related to a new feature. label Nov 12, 2021
@mdbooth
Copy link
Contributor

mdbooth commented Nov 15, 2021

This sounds like a good feature to me. I don't feel like we should propagate tags to cluster status.

Additionally I wonder if, in general, we should update tags on existing resources. We don't modify the resources themselves after creation, but tags are metadata. Does this immutability include tags? The ability to change tags on existing resources seems useful both to us as developers: to fix a bug at resource creation time, and to users: to change the way resources are identified in a cloud after creation.

@jichenjc
Copy link
Contributor

+1 to include tags to the resource created by CAPO

The ability to change tags on existing resources seems useful both to us as developers

so your suggestion is to allow the update of openstackmachine related CRD so reconcile can update the
openstack resources accordingly? I see no reason to block such as update tag seems reasonable as Day2 operations

@nikParasyr
Copy link
Contributor Author

The ability to change tags on existing resources seems useful both to us as developers

This does indeed sound like a nice addition. I'd say though that it possibly exceeds tags on SGs, at least all tagged resources, and possibly other configs that can be updated and seem reasonable to be changed as day2 operations. I think this should be tackled in a separate issue though.

For the time being, I opened a PR just adding tags on SGs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants