Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

We assume ControlPlaneEndpoint.Host is IP address #1714

Closed
mdbooth opened this issue Oct 6, 2023 · 1 comment · Fixed by #1738
Closed

We assume ControlPlaneEndpoint.Host is IP address #1714

mdbooth opened this issue Oct 6, 2023 · 1 comment · Fixed by #1738
Labels
kind/bug Categorizes issue or PR as related to a bug. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale.

Comments

@mdbooth
Copy link
Contributor

mdbooth commented Oct 6, 2023

/kind bug

From code inspection, we set fixedIPAddress to ControlPlaneEndpoint.Host if not using APIServer FloatingIP:

switch {
case openStackCluster.Spec.APIServerFixedIP != "":
fixedIPAddress = openStackCluster.Spec.APIServerFixedIP
case openStackCluster.Spec.DisableAPIServerFloatingIP && openStackCluster.Spec.ControlPlaneEndpoint.IsValid():
fixedIPAddress = openStackCluster.Spec.ControlPlaneEndpoint.Host
}

We then pass that to getOrCreateLoadBalancer, which expects it to be a VipAddress:

lbCreateOpts := loadbalancers.CreateOpts{
Name: loadBalancerName,
VipSubnetID: subnetID,
VipAddress: vipAddress,
Description: names.GetDescription(clusterName),
Provider: provider,
Tags: openStackCluster.Spec.Tags,
}
lb, err = s.loadbalancerClient.CreateLoadBalancer(lbCreateOpts)

However, ControlPlaneEndpoint.Host is not required to be an IP address. It may be a DNS name.

Same when creating the load balancer FIP:

switch {
case openStackCluster.Spec.APIServerFloatingIP != "":
floatingIPAddress = openStackCluster.Spec.APIServerFloatingIP
case openStackCluster.Spec.ControlPlaneEndpoint.IsValid():
floatingIPAddress = openStackCluster.Spec.ControlPlaneEndpoint.Host
}

@k8s-ci-robot k8s-ci-robot added the kind/bug Categorizes issue or PR as related to a bug. label Oct 6, 2023
@mdbooth mdbooth changed the title We assume ControlPlaneEndpoint.Host is IP address in ReconcileLoadBalancer We assume ControlPlaneEndpoint.Host is IP address Oct 6, 2023
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue as fresh with /remove-lifecycle stale
  • Close this issue with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jan 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale.
Projects
None yet
3 participants