Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OpenStackCluster.Status.Ready being required causing issues in reconcile #1841

Closed
EmilienM opened this issue Jan 25, 2024 · 3 comments · Fixed by #1842
Closed

OpenStackCluster.Status.Ready being required causing issues in reconcile #1841

EmilienM opened this issue Jan 25, 2024 · 3 comments · Fixed by #1842
Assignees
Labels
kind/bug Categorizes issue or PR as related to a bug.
Milestone

Comments

@EmilienM
Copy link
Contributor

/kind bug

What steps did you take and what happened:

When fixing #1838 - I noticed this error in our logs:

OpenStackCluster.infrastructure.cluster.x-k8s.io \"cluster-e2e-rha0r3\" is invalid: ready: Required value"

This is because the reconcile leaves early when the OpenStackCluster.Status.Ready is not set yet and this field is required.
I think this think should not be required like it's the case for the OpenStackMachine.Status.Ready (omitempty) so we don't have these troubles.

@k8s-ci-robot k8s-ci-robot added the kind/bug Categorizes issue or PR as related to a bug. label Jan 25, 2024
@EmilienM
Copy link
Contributor Author

/assign EmilienM

@EmilienM
Copy link
Contributor Author

@kubernetes-sigs/cluster-api-provider-openstack-maintainers please add v1beta1 to milestone.

@lentzi90 lentzi90 added this to the v1beta1 milestone Jan 26, 2024
@mdbooth
Copy link
Contributor

mdbooth commented Jan 30, 2024

I don't currently see this as a v1beta1 issue, btw. It's a bug, but I don't think it's an API issue. I think the error message is a red herring and indicates some code problem elsewhere.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants