Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

node deletion can't delete node #1055

Closed
chuckha opened this issue Jun 21, 2019 · 4 comments · Fixed by #1052
Closed

node deletion can't delete node #1055

chuckha opened this issue Jun 21, 2019 · 4 comments · Fixed by #1052
Assignees
@vincepri
Labels
area/machine Issues or PRs related to machine lifecycle management kind/bug Categorizes issue or PR as related to a bug. lifecycle/active Indicates that an issue or PR is actively being worked on by a contributor. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release.
Milestone
v0.2.0 (v1alpha2)

Comments

@chuckha
Copy link
Contributor

chuckha commented Jun 21, 2019

/kind bug

It might be my misunderstanding, but deleting a node doesn't make sense. The machine actuator has a client to the management cluster, but, unless I'm misunderstanding what 'node' means here, it has no way to delete the node object from the target cluster. What node object is cluster-api trying to delete? I'm specifically referencing https://github.com/kubernetes-sigs/cluster-api/blob/master/pkg/controller/machine/machine_controller.go#L277 this code.

Perhaps it's special code only meant to manage nodes on the management cluster and the provider must manage removal of nodes from target cluster?
@k8s-ci-robot k8s-ci-robot added the kind/bug Categorizes issue or PR as related to a bug. label Jun 21, 2019
@ncdc
Copy link
Contributor

ncdc commented Jun 21, 2019

The assumption in the code you linked is that there is only one cluster, performing the roles of management cluster and workload cluster, together. With the work that @vincepri has been doing to support remote node references, this will need to be adjusted. And that's what he's done in #1052 😄 (not merged yet)

@ncdc
Copy link
Contributor

ncdc commented Jun 21, 2019

/assign @vincepri
/milestone v1alpha2
/priority important-soon
/area machine

@k8s-ci-robot k8s-ci-robot added this to the v1alpha2 milestone Jun 21, 2019
@k8s-ci-robot k8s-ci-robot added priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. area/machine Issues or PRs related to machine lifecycle management labels Jun 21, 2019
@ncdc
Copy link
Contributor

ncdc commented Jun 21, 2019

/lifecycle active

@k8s-ci-robot k8s-ci-robot added the lifecycle/active Indicates that an issue or PR is actively being worked on by a contributor. label Jun 21, 2019
@vincepri vincepri mentioned this issue Jun 21, 2019
Merged
@chuckha
Copy link
Contributor Author

chuckha commented Jun 21, 2019

haha trust @vincepri to solve my problems before I know I have them

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vincepri vincepri

Labels
area/machine Issues or PRs related to machine lifecycle management kind/bug Categorizes issue or PR as related to a bug. lifecycle/active Indicates that an issue or PR is actively being worked on by a contributor. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release.
Projects
None yet
Milestone
v0.2.0 (v1alpha2)
Development

Successfully merging a pull request may close this issue.

Use remote NodeRef in Machine and MachineSet controllers vincepri/cluster-api
4 participants
@ncdc @chuckha @vincepri @k8s-ci-robot