Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix release notes generation tools for manual cherry-picked PR #11377

Open
chandankumar4 opened this issue Nov 5, 2024 · 3 comments
Open

Fix release notes generation tools for manual cherry-picked PR #11377

chandankumar4 opened this issue Nov 5, 2024 · 3 comments
Assignees
@chandankumar4
Labels
area/release Issues or PRs related to releasing kind/bug Categorizes issue or PR as related to a bug. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. triage/accepted Indicates an issue or PR is ready to be actively worked on.

Comments

@chandankumar4
Copy link
Contributor

What steps did you take and what happened?

Release notes generation tools is breaking while generating the release notes for v1.8.5, error is

What did you expect to happen?

Release notes tools should be generating the release notes without any failure, currently it's failing with below error from this line

2024/11/04 20:00:31 expected 10 PRs from commit list but only found 9
make: *** [release-notes] Error 1

Step to reproduce:

  • Generate the release notes for version v1.8.5 using command RELEASE_TAG=v1.8.5 make release-notes

Cluster API version

v1.8.5

Kubernetes version

No response

Anything else you would like to add?

No response

Label(s) to be applied

/kind bug
/area release
One or more /area label. See https://github.com/kubernetes-sigs/cluster-api/labels?q=area for the list of labels.
@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. area/release Issues or PRs related to releasing needs-priority Indicates an issue lacks a `priority/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Nov 5, 2024
@chandankumar4
Copy link
Contributor Author

/assign @chandankumar4

@sbueringer
Copy link
Member

sbueringer commented Nov 5, 2024 •
edited
Loading

Really wondering what makes "manual cherry-picked PR" special. Regular PRs, cherry-picked PRs with and without the bot should all work :)

@sbueringer sbueringer added the priority/backlog Higher priority than priority/awaiting-more-evidence. label Nov 13, 2024
@k8s-ci-robot k8s-ci-robot removed the needs-priority Indicates an issue lacks a `priority/foo` label and requires one. label Nov 13, 2024
@sbueringer sbueringer added priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. and removed priority/backlog Higher priority than priority/awaiting-more-evidence. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. labels Nov 13, 2024
@sbueringer
Copy link
Member

/triage accepted

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Nov 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@chandankumar4 chandankumar4

Labels
area/release Issues or PRs related to releasing kind/bug Categorizes issue or PR as related to a bug. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@sbueringer @k8s-ci-robot @chandankumar4