-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support JSON log format #5571
Comments
@randomvariable Can you maybe please add some additional context. It sounded like there is more history / related issues on this (#5336 (comment) and #5336 (comment)). |
Let's make this an opt-in flag /milestone v1.1 |
The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs. This bot triages issues and PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle stale |
/lifecycle frozen |
Update from the exploration on PR #6072:
I think we should consider using components-base/logs as it provides us a lot of useful features:
My opinion: I think it makes sense to deprecate the klog flags in ClusterAPI too for the same reasons mentioned in the KEP (tl;dr mainly 12 factor apps => drop flags for file logging). Related issues:
References:
|
Just fyi. The klog version we currently use has an issue that it doesn't propagate verbosity correctly, i.e. with JSON log format the I expect that there will be a new klog version that we can pick up with the next Kubernetes / controller-runtime release before our release. Independent of that, I don't think it should block us as the JSON log format is currently alpha. |
User Story
As a user I would like to be able to run the CAPI controllers with JSON log format as it's easier to parse (e.g. could be easily parsed in Loki LogQL queries).
Detailed Description
We're already using structured logging in our code (on the logger with k/v pairs), but it's currently not possible to actually configure our controllers to log in JSON format.
Anything else you would like to add:
This issue came up here: #5336 (comment)
/kind feature
(couldn't find a better area)
/area health
The text was updated successfully, but these errors were encountered: