Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move webhook implementation to webhooks/internal #5599

Closed
killianmuldoon opened this issue Nov 5, 2021 · 4 comments · Fixed by #5711
Closed

Move webhook implementation to webhooks/internal #5599

killianmuldoon opened this issue Nov 5, 2021 · 4 comments · Fixed by #5711
Assignees
@kaitoii11
Labels
area/clusterclass Issues or PRs related to clusterclass kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt.
Milestone
v1.1

Comments

@killianmuldoon
Copy link
Contributor

As with ##5455 functions and types that are being placed in the new top level webhooks package should be made internal by default.

c/f #5594
@sbueringer
Copy link
Member

sbueringer commented Nov 8, 2021 •
edited
Loading

/area topology
(kind of)

/kind cleanup

@k8s-ci-robot k8s-ci-robot added area/topology kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. labels Nov 8, 2021
@fabriziopandini
Copy link
Member

/milestone v1.1

@k8s-ci-robot k8s-ci-robot added this to the v1.1 milestone Nov 15, 2021
@kaitoii11
Copy link
Contributor

/assign

@killianmuldoon
Copy link
Contributor Author

Thanks @kaitoii11 let me know if you need any help with this. 😃

@kaitoii11 kaitoii11 mentioned this issue Nov 19, 2021
Merged
@nprokopic nprokopic mentioned this issue Jun 27, 2022
Closed
This was referenced Sep 2, 2022
Closed
Closed
@killianmuldoon killianmuldoon added the area/clusterclass Issues or PRs related to clusterclass label May 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kaitoii11 kaitoii11

Labels
area/clusterclass Issues or PRs related to clusterclass kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt.
Projects
None yet
Milestone
v1.1
Development

Successfully merging a pull request may close this issue.

🌱 Move webhooks to internal kaitoii11/cluster-api
5 participants
@sbueringer @fabriziopandini @kaitoii11 @k8s-ci-robot @killianmuldoon