Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

configuable timeoutKubeconfigReady #961

Closed
xunpan opened this issue May 29, 2019 · 6 comments · Fixed by #1026
Closed

configuable timeoutKubeconfigReady #961

xunpan opened this issue May 29, 2019 · 6 comments · Fixed by #1026
Assignees
Labels
kind/feature Categorizes issue or PR as related to a new feature. lifecycle/active Indicates that an issue or PR is actively being worked on by a contributor. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete.

Comments

@xunpan
Copy link

xunpan commented May 29, 2019

/kind feature

Describe the solution you'd like
For deploying a different release of Kubernetes, e.g. ICP, the default time out for 20m may be not enough in waiting for cluster ready.

It should be better configurable by command line options.

Anything else you would like to add:
[Miscellaneous information that will assist in solving the issue.]

@k8s-ci-robot k8s-ci-robot added the kind/feature Categorizes issue or PR as related to a new feature. label May 29, 2019
@wanghh2000
Copy link
Contributor

@xunpan You want a parameter like "--timeoutForWaitingTargetCluster 30" from Clusterctl to update timeoutKubeconfigReady in case creating a cluster is very long process. Right?

@gyliu513
Copy link
Contributor

gyliu513 commented Jun 4, 2019

@wanghh2000 @xunpan You can post a PR like this kubernetes-sigs/cluster-api-provider-openstack#262 which was fixed by @jichenjc for OpenStack.

@wanghh2000
Copy link
Contributor

@gyliu513
Shouldn't the timeout be a common feature from clusterctl for all provider projects?
Do you mean that add a timeout in each provider to handle instead of a common clusterctl parameter?

@jichenjc
Copy link
Contributor

jichenjc commented Jun 4, 2019

that's doable, It will increase a lot of options since we have a set of timeout options...
and our provider is running in container (statefulset), we need transfer that from clusterctl exec file to the container as well

@wanghh2000
Copy link
Contributor

@jichenjc OK, I will reference what you did.

@timothysc timothysc added this to the v1alpha2 milestone Jun 14, 2019
@timothysc timothysc added the priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. label Jun 14, 2019
@vincepri
Copy link
Member

/lifecycle active

@k8s-ci-robot k8s-ci-robot added the lifecycle/active Indicates that an issue or PR is actively being worked on by a contributor. label Jun 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature. lifecycle/active Indicates that an issue or PR is actively being worked on by a contributor. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants