New LogConstructur causes all loggers to report the same metadata

[maboehm]

After upgrading to v0.12.0 all our reconciler loggers have the same controller, controllerGroup and controllerKind set.

I believe this is caused by https://github.com/kubernetes-sigs/controller-runtime/blob/master/pkg/builder/controller.go#L312, where it should be log := or maybe to avoid confusion name the variable differently. This was introduced with #1827.
I guess it is done similarly here: https://github.com/kubernetes-sigs/controller-runtime/blob/master/pkg/controller/controller.go#L110

[maboehm]

seems like #1907 will be fixing this

[alvaroaleman]

Fixed in #1907, thanks for the report!