You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
We are facing an issue with controller-runtime while creating integration-tests for scheduler-plugin. We would appreciate your comments on this.
In this PR, we have created integration test using mgr.Start(ctrl.SetupSignalHandler()). However, as another test also uses mgr.Start(ctrl.SetupSignalHandler()), we are encountering a panic error.
panic: close of closed channel
goroutine 9857 [running]:
sigs.k8s.io/controller-runtime/pkg/manager/signals.SetupSignalHandler()
/home/prow/go/src/sigs.k8s.io/scheduler-plugins/vendor/sigs.k8s.io/controller-runtime/pkg/manager/signals/signal.go:31 +0x25
sigs.k8s.io/scheduler-plugins/test/integration.TestPodGroupController.func1()
/home/prow/go/src/sigs.k8s.io/scheduler-plugins/test/integration/podgroup_controller_test.go:78 +0x32
created by sigs.k8s.io/scheduler-plugins/test/integration.TestPodGroupController
/home/prow/go/src/sigs.k8s.io/scheduler-plugins/test/integration/podgroup_controller_test.go:77 +0x3dd
FAIL sigs.k8s.io/scheduler-plugins/test/integration 356.228s
I think this is because ctrl.SetupSignalHandler is being executed twice in a single go test.
Could you suggest how we can implement integration test in such cases?
The text was updated successfully, but these errors were encountered:
We are facing an issue with controller-runtime while creating integration-tests for scheduler-plugin. We would appreciate your comments on this.
In this PR, we have created integration test using
mgr.Start(ctrl.SetupSignalHandler())
. However, as another test also usesmgr.Start(ctrl.SetupSignalHandler())
, we are encountering a panic error.I think this is because
ctrl.SetupSignalHandler
is being executed twice in a singlego test
.Could you suggest how we can implement integration test in such cases?
The text was updated successfully, but these errors were encountered: