Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

'crictl rm(p) -af' display help when there is nothing to delete #1144

Closed
champtar opened this issue Apr 28, 2023 · 2 comments · Fixed by #1147
Closed

'crictl rm(p) -af' display help when there is nothing to delete #1144

champtar opened this issue Apr 28, 2023 · 2 comments · Fixed by #1147
Labels
kind/bug Categorizes issue or PR as related to a bug. sig/node Categorizes an issue or PR as relevant to SIG Node.

Comments

@champtar
Copy link
Contributor

What happened:

Using

crictl rmp -af
crictl rm -af

display the help menu when there are no containers/pods left to delete

What you expected to happen:

either display nothing or a message saying that there is nothing to delete

How to reproduce it (as minimally and precisely as possible):

run crictl rm -af twice

Anything else we need to know?:

Environment:

  • Container runtime or hardware configuration: containerd 1.7.0 / crictl 1.26.0
@champtar champtar added kind/bug Categorizes issue or PR as related to a bug. sig/node Categorizes an issue or PR as relevant to SIG Node. labels Apr 28, 2023
@saschagrunert
Copy link
Member

@champtar good point, do you mind opening a PR to fix that behavior?

@champtar
Copy link
Contributor Author

@saschagrunert #1147

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug. sig/node Categorizes an issue or PR as relevant to SIG Node.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants