Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

crictl ps command . If Image column should show image digest? #1766

Open
jokemanfire opened this issue Feb 8, 2025 · 4 comments
Open

crictl ps command . If Image column should show image digest? #1766

jokemanfire opened this issue Feb 8, 2025 · 4 comments

Comments

@jokemanfire
Copy link
Contributor

I feel confuse about crictl ps -r . If we should use 'ImageRef' instead of Image.image? If it is coding negligence, I'd like to file change.

@saschagrunert
Copy link
Member

@jokemanfire thank you for opening the issue! We use r.Imge.RepoTags if available:

if len(r.Image.RepoTags) > 0 {
return r.Image.RepoTags[0], nil
}

To which field is the imageRef referring to?

@jokemanfire
Copy link
Contributor Author

jokemanfire commented Feb 10, 2025

In proto ,it should be the digest id .

Image

@saschagrunert
Copy link
Member

@jokemanfire the image_ref will resolve mostly into the digest value, which is different from the repo tag value. It's tricky, but changing the behavior will definitely be a breaking one.

@jokemanfire
Copy link
Contributor Author

Let me confirm that the Image column was originally designed to display the digest ID? Using the '- r' parameter is the tag that displays the image. Is that?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants