Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests broken in master branch #4825

Closed
Raffo opened this issue Oct 23, 2024 · 1 comment · Fixed by #4832
Closed

Tests broken in master branch #4825

Raffo opened this issue Oct 23, 2024 · 1 comment · Fixed by #4832
Assignees
Labels
kind/bug Categorizes issue or PR as related to a bug.

Comments

@Raffo
Copy link
Contributor

Raffo commented Oct 23, 2024

What happened:

Tests don't pass, sse: https://prow.k8s.io/view/gs/kubernetes-ci-logs/logs/post-external-dns-push-images/1848748383435493376

What you expected to happen:

Tests are green

How to reproduce it (as minimally and precisely as possible):

Run tests in master.

@Raffo Raffo added the kind/bug Categorizes issue or PR as related to a bug. label Oct 23, 2024
@Raffo Raffo self-assigned this Oct 23, 2024
@Raffo
Copy link
Contributor Author

Raffo commented Oct 23, 2024

Note: I think there's something funky going on, I can reproduce the tests on one of my machines, but not on another. Looks like the data structures are different, array vs non array. I will have to investigate why.

=== RUN   TestAWSSDProvider_awsTags
    aws_sd_test.go:1007:
        	Error Trace:	/Users/raffo/go/src/sigs.k8s.io/external-dns/provider/awssd/aws_sd_test.go:1007
        	Error:      	Not equal:
        	            	expected: []types.Tag{types.Tag{Key:(*string)(0x14000342d80), Value:(*string)(0x14000342d90), noSmithyDocumentSerde:document.NoSerde{}}, types.Tag{Key:(*string)(0x14000342da0), Value:(*string)(0x14000342db0), noSmithyDocumentSerde:document.NoSerde{}}}
        	            	actual  : []types.Tag{types.Tag{Key:(*string)(0x14000342dc0), Value:(*string)(0x14000342dd0), noSmithyDocumentSerde:document.NoSerde{}}, types.Tag{Key:(*string)(0x14000342de0), Value:(*string)(0x14000342df0), noSmithyDocumentSerde:document.NoSerde{}}}

        	            	Diff:
        	            	--- Expected
        	            	+++ Actual
        	            	@@ -1,2 +1,8 @@
        	            	 ([]types.Tag) (len=2) {
        	            	+ (types.Tag) {
        	            	+  Key: (*string)((len=4) "key2"),
        	            	+  Value: (*string)((len=6) "value2"),
        	            	+  noSmithyDocumentSerde: (document.NoSerde) {
        	            	+  }
        	            	+ },
        	            	  (types.Tag) {
        	            	@@ -6,8 +12,2 @@
        	            	   }
        	            	- },
        	            	- (types.Tag) {
        	            	-  Key: (*string)((len=4) "key2"),
        	            	-  Value: (*string)((len=6) "value2"),
        	            	-  noSmithyDocumentSerde: (document.NoSerde) {
        	            	-  }
        	            	  }
        	Test:       	TestAWSSDProvider_awsTags
--- FAIL: TestAWSSDProvider_awsTags (0.00s)
FAIL
FAIL	sigs.k8s.io/external-dns/provider/awssd	1.699s

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant