Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[gwctl] Improvement: Separate describeViews into separate packages to make code reusable as a library #2435

Closed
gauravkghildiyal opened this issue Sep 27, 2023 · 3 comments
Closed

[gwctl] Improvement: Separate describeViews into separate packages to make code reusable as a library #2435

gauravkghildiyal opened this issue Sep 27, 2023 · 3 comments
Assignees
@gauravkghildiyal
Labels
kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one.

Comments

@gauravkghildiyal
Copy link
Member

@robscott made a great suggestion about separating the describeViews in the code (which are just used for CLI output) from the code pieces which we intend to make usable as a library.

This issue tracks the work to refactor code in such a way.

While separating describeViews provides us a good (and actionable) start, thought should also be given about other ways to make things reusable as a library.

/assign
@gauravkghildiyal gauravkghildiyal added the kind/bug Categorizes issue or PR as related to a bug. label Sep 27, 2023
@gauravkghildiyal
Copy link
Member Author

/kind cleanup

@k8s-ci-robot k8s-ci-robot added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label Sep 27, 2023
@gauravkghildiyal
Copy link
Member Author

/remove-kind bug

@k8s-ci-robot k8s-ci-robot removed the kind/bug Categorizes issue or PR as related to a bug. label Sep 27, 2023
@gauravkghildiyal gauravkghildiyal mentioned this issue Sep 27, 2023
Merged
@shaneutt shaneutt added the needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. label Sep 27, 2023
@gauravkghildiyal
Copy link
Member Author

This has already been incorporated in #2428.

@github-project-automation github-project-automation bot moved this from Triage to Done in Gateway API: The Road to GA Oct 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gauravkghildiyal gauravkghildiyal

Labels
kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one.
Projects
No open projects
Gateway API: The Road to GA
Status: Done
Milestone
No milestone
Development

No branches or pull requests
3 participants
@shaneutt @k8s-ci-robot @gauravkghildiyal