Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BackendTLSPolicy: Add CEL Tests #2473

Closed
robscott opened this issue Oct 11, 2023 · 1 comment · Fixed by #2491
Closed

BackendTLSPolicy: Add CEL Tests #2473

robscott opened this issue Oct 11, 2023 · 1 comment · Fixed by #2491
Labels
kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. kind/test
Milestone
v1.0.0

Comments

@robscott
Copy link
Member

What would you like to be added:
Tests to ensure the CEL validation added in #2448 is working as expected.

Why this is needed:
All other CEL validations have corresponding go tests in https://github.com/kubernetes-sigs/gateway-api/tree/main/pkg/test/cel. Without it, it's awfully hard to ensure that the CEL we've written covers all the inputs we want to allow or prevent.
@robscott robscott added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. kind/test labels Oct 11, 2023
@robscott robscott mentioned this issue Oct 11, 2023
Merged
@Ygnas
Copy link
Contributor

Ygnas commented Oct 12, 2023 •
edited
Loading

I'm going to look into it, as I believe I have hit a problem with the rules

@shaneutt shaneutt added this to the v1.0.0 milestone Oct 12, 2023
@Ygnas Ygnas mentioned this issue Oct 17, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. kind/test
Projects
No open projects
Gateway API: The Road to GA
Status: Done
Milestone
v1.0.0
Development

Successfully merging a pull request may close this issue.

BackendTLSPolicy cel tests Ygnas/gateway-api
3 participants
@robscott @shaneutt @Ygnas