Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generic version of debug-tools for executables #518

Closed
jayunit100 opened this issue Feb 22, 2021 · 6 comments · Fixed by #534
Closed

Generic version of debug-tools for executables #518

jayunit100 opened this issue Feb 22, 2021 · 6 comments · Fixed by #534
Assignees
Labels
kind/feature Categorizes issue or PR as related to a new feature. sig/windows Categorizes an issue or PR as relevant to SIG Windows.

Comments

@jayunit100
Copy link
Contributor

Is your feature request related to a problem? Please describe.

feature - for windows, we need executables for CSI, CNI, and so on that are hollow , i.e. not really aware of cni or csi, but just, copying executables installed to image

Describe the solution you'd like

  • Add an ansible step "cni-executables-install/" OR
  • Add an ansible step "additional-file-copy/"

Describe alternatives you've considered

  • Make a container and unzip it at runtime
  • post kubeadm wget actions yuck !

Additional context

@perithompson and me want to ship Antrea in windows images !

/kind feature

@k8s-ci-robot k8s-ci-robot added the kind/feature Categorizes issue or PR as related to a new feature. label Feb 22, 2021
@perithompson
Copy link
Contributor

/sig windows

@k8s-ci-robot k8s-ci-robot added the sig/windows Categorizes an issue or PR as relevant to SIG Windows. label Feb 22, 2021
@jsturtevant
Copy link
Contributor

A little background... Since windows doesn't have privileged containers it can't easily install and run services from pods like Linux does. sig-windows came up with some work arounds using hostnetwork for Windows and Docker but it doesn't work as well with Containerd: kubernetes-sigs/sig-windows-tools#128 (comment)

For now with Containerd, in the current state of things it is necessary for containerd builds to have the CNI running on the node. This will be temporary once privileged containers lands and matures (which would make it closer to the way Linux install and run CNI's)

If this could be designed to be generic to install not just Antrea that would be beneficial for capz as well.

@perithompson
Copy link
Contributor

Completely agree with this, we were thinking as a generic way to do this, we could just start with a way to download a variable list of executables into a folder for CSI/CNI etc and let cluster API do the actual installation step? Any thoughts? I think maintaining an installation routine for each cni would be to hard to maintain...

@jsturtevant
Copy link
Contributor

Agreed, Linux does something similar for the base line cnis:

The tricky part might be setting up the configuraiton between containerd/CNI/kubelet.

@jayunit100
Copy link
Contributor Author

im ok w ANY solution here, generic or CNI specific , but feel like generic gives max flexibility to vendors w/o making upstream opinionated

@perithompson
Copy link
Contributor

/assign

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature. sig/windows Categorizes an issue or PR as relevant to SIG Windows.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants