-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add some EventRecorder events from jobset #506
Comments
/assign |
@danielvegamyhre @kannon92 Can I attempt to enhance this feature? |
I'm not sure if the pod controller also needs the related events generated by EventRecorder. I don't think we would specifically look at the pods generated by the jobset. |
I don't think an event for failing to delete a job is needed. Failing to create jobs is what we care about more; specifically, the first failed job which led to the jobset failing. We have an event emitted for this already. |
@danielvegamyhre I have also added events for the failure to delete a job and the failure to create a headless service. So, the meaning is to keep the latter and remove the former, right? |
Done!thanks @danielvegamyhre @kannon92 |
What would you like to be added:
I noticed that the events generated by EventRecorder are not comprehensive enough. I plan to add more events in the controller, such as events for handling deletion errors or generating some common errors
Why is this needed:
The events generated by EventRecorder can be viewed for more critical events when executing kubectl describe jobset.
The text was updated successfully, but these errors were encountered: