Bug in testing utility function JobSetActive

[danielvegamyhre]

@jedwins1998 encountered a bug when working on tests for configurable failure policy changes, tests would pass when using JobSetFailed() to check the JobSet has a failed condition type with a status of true, but also would pass when JobSetFailed() was changed to JobSetActive().

I think this is because in JobSetActive we are simply passing in an empty list of conditions to checkJobSetStatus, which verifies all given conditions are set on the jobset status.

However, even for a failed JobSet, the number of conditions matching an empty list of conditions will be 0, and the check will return ok, which it should not.

Instead, we should change JobSetActive to verify there are no mutually exclusive conditions set on the JobSet status, like failed or completed.

[jedwins1998]

/assign

[jedwins1998]

The JobSet condition types are defined here.

I am planning to apply the definition that a JobSet is considered active as long as none of the following conditions have a status of true:

1. JobSetCompleted,
2. JobSetFailed,
3. JobSetSuspended.

In particular, an active JobSet can still have the conditions JobSetStartupPolicyInProgress and JobSetStartupPolicyCompleted with any given status. Please comment if you see potential issues with this definition.