Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CronJobs in a namespace preventing consolidation #1921

Open
rkilingr opened this issue Jan 16, 2025 · 2 comments
Open

CronJobs in a namespace preventing consolidation #1921

rkilingr opened this issue Jan 16, 2025 · 2 comments
Labels
kind/bug Categorizes issue or PR as related to a bug. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one.

Comments

@rkilingr
Copy link

rkilingr commented Jan 16, 2025

Description

Observed Behavior:
We have a bunch of cronjobs running on a namespace with a maximum frequency of every 15m. Karpenter seems to be taking that into account on field lastPodEventTime preventing the node to be considered as Consolidatable

Expected Behavior:
CronJobs and ephemeral pods should not prevent node consolidation

Reproduction Steps (Please include YAML):
Have a nodepool with a spec.disruption.consolidateAfter field set to a duration longer than cronjob frequency, example 60m

Versions:

  • Chart Version: v1.0.6
  • Kubernetes Version (kubectl version): Server Version: version.Info{Major:"1", Minor:"30+", GitVersion:"v1.30.8-eks-2d5f260", GitCommit:"3c9802b10b3530b22ddb4727e2931f6b89bbb760", GitTreeState:"clean", BuildDate:"2024-12-12T23:09:04Z", GoVersion:"go1.22.9", Compiler:"gc", Platform:"linux/amd64"}
  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment
@rkilingr rkilingr added the kind/bug Categorizes issue or PR as related to a bug. label Jan 16, 2025
@k8s-ci-robot k8s-ci-robot added the needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. label Jan 16, 2025
@k8s-ci-robot
Copy link
Contributor

This issue is currently awaiting triage.

If Karpenter contributors determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@sftim
Copy link

sftim commented Jan 20, 2025

This sounds like a feature you'd like Karpenter to implement: a way to protect a node from consolidation to protect managed Jobs (eg managed by a CronJob).

The behaviour you've stated as expected isn't something we document as available.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one.
Projects
None yet
Development

No branches or pull requests

3 participants