Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dualstack should automatically enable feature gate for < 1.21 #2172

Closed
BenTheElder opened this issue Apr 1, 2021 · 2 comments · Fixed by #2173
Closed

dualstack should automatically enable feature gate for < 1.21 #2172

BenTheElder opened this issue Apr 1, 2021 · 2 comments · Fixed by #2173
Assignees
Labels
kind/bug Categorizes issue or PR as related to a bug.
Milestone

Comments

@BenTheElder
Copy link
Member

see: https://kubernetes.slack.com/archives/CEKK1KTN2/p1617232113200400

note: we can be smart and enable this precisely before it comes on by default 🙃, see e.g. a4df15b#diff-1d8da887aaff57615ed7bc578730aff0c89074cb92ba7f5ef2bcb6536f9ae521R110

filing so we don't lose track, I can do this in the morning though, been working on #166.

cc @aojea

@BenTheElder BenTheElder added the kind/bug Categorizes issue or PR as related to a bug. label Apr 1, 2021
@BenTheElder
Copy link
Member Author

also: we need to get a kind CI job. maybe just a small subset of tests on kubernetes master in kind presubmit for now (we need to avoid excessively expanding presubmit in this repo and we already subject ourselves to equivalents of all kubernetes/kubernetes presubmits using kind).

@BenTheElder BenTheElder added this to the v0.11.0 milestone Apr 1, 2021
@aojea
Copy link
Contributor

aojea commented Apr 1, 2021

also: we need to get a kind CI job. maybe just a small subset of tests on kubernetes master in kind presubmit for now (we need to avoid excessively expanding presubmit in this repo and we already subject ourselves to equivalents of all kubernetes/kubernetes presubmits using kind).

There are 2 periodic KIND dual-stack jobs (ipvs and iptables proxy) and 2 optional presubmits already
https://testgrid.k8s.io/sig-network-kind#sig-network-kind,%20dual,%20master&width=20
https://testgrid.k8s.io/sig-network-kind#pr-sig-network-kind,%20dual&width=20

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants