Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add nerdctl to kind #2517

Closed
jonyhy96 opened this issue Oct 27, 2021 · 8 comments
Closed

Add nerdctl to kind #2517

jonyhy96 opened this issue Oct 27, 2021 · 8 comments
Assignees
Labels
kind/feature Categorizes issue or PR as related to a new feature.

Comments

@jonyhy96
Copy link

jonyhy96 commented Oct 27, 2021

What would you like to be added:

Add nerdctl to kind because it is very friendly to people who are familiar with docker-cli rather than ctr.

Why is this needed:

And add nerdctl to kind will make it more easy to use on testing purposes.

@jonyhy96 jonyhy96 added the kind/feature Categorizes issue or PR as related to a new feature. label Oct 27, 2021
@jonyhy96
Copy link
Author

/cc @aojea
If this is accepted, i would like to help with it.

@aojea
Copy link
Contributor

aojea commented Oct 27, 2021

per the comment

Supporting containerd via nerdctl (https://github.com/containerd/nerdctl) would be quite straight forward. Almost just alias docker=nerdctl.

doesn't seem KIND needs to add anything

@jonyhy96
Copy link
Author

per the comment

Supporting containerd via nerdctl (https://github.com/containerd/nerdctl) would be quite straight forward. Almost just alias docker=nerdctl.

doesn't seem KIND needs to add anything

Yes, it is actualy saying use nerdctl instead docker-cli to create kind container when backend by containerd. My bad.

BTW, what do u think about add nerdctl inside kind's image (/usr/local/bin) for use?

@BenTheElder
Copy link
Member

BenTheElder commented Oct 29, 2021

this is perhaps a bit clearer, but essentially a dupe of #2317?

@BenTheElder
Copy link
Member

BenTheElder commented Oct 29, 2021

BTW, what do u think about add nerdctl inside kind's image (/usr/local/bin) for use?

We already provide ctr (which we currently use internally) and crictl (which is a standard tool portable across kubernetes clusters), which add a fair bit to the image size. As big as the images are we do everything we can to keep them lighter.

User workloads really shouldn't be talking to the node runtime directly. You should use the Kubernetes APIs .. 🤔

@jonyhy96
Copy link
Author

BTW, what do u think about add nerdctl inside kind's image (/usr/local/bin) for use?

We already provide ctr (which we currently use internally) and crictl (which is a standard tool portable across kubernetes clusters), which add a fair bit to the image size. As big as the images are we do everything we can to keep them lighter.

User workloads really shouldn't be talking to the node runtime directly. You should use the Kubernetes APIs .. 🤔

Thanks for reply! I was trying to lean how node runtime works in KIND and i found that nerdctl is more easy to use(for me). So I guess someone should have the same needs as me. It is ok if we don't add it to the base image for keep it lighter.Just a suggestion 😄

@BenTheElder
Copy link
Member

I think probably we should be considering adding support for nerdctl/lima (especially if someone wants to outline the approach and take it on themselves), but currently even the podman support is a bit lacking (see e.g. #2038).

Within the nodes I think we should not add this additional tool, preferring the Kubernetes API instead (and we do also provide ctr since we depend on it internally, and probably others do now).

@BenTheElder BenTheElder self-assigned this Nov 2, 2021
@BenTheElder
Copy link
Member

#3445, #3429

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Development

No branches or pull requests

3 participants