Use bash to run 'test' Makefile target

[Wastack]

Let's assume I have /bin/sh as default shell. But error occurs also if I don't have $SHELL explicitly set (because GNU Make defaults to sh).

When running make test I have the following error messages:

/my/path/to/project/bin/controller-gen "crd:trivialVersions=true,preserveUnknownFields=false" rbac:roleName=manager-role webhook paths="./..." output:crd:artifacts:config=config/crd/bases
/my/path/to/project/bin/controller-gen object:headerFile="hack/boilerplate.go.txt" paths="./..."
go fmt ./...
go vet ./...
mkdir -p /my/path/to/project/bin
test -f /my/path/to/project/bin/setup-envtest.sh || curl -sSLo /my/path/to/project/bin/setup-envtest.sh https://raw.githubusercontent.com/kubernetes-sigs/controller-runtime/v0.7.2/hack/setup-envtest.sh
source /my/path/to/project/bin/setup-envtest.sh; fetch_envtest_tools /my/path/to/project/bin; setup_envtest_env /my/path/to/project/bin; go test ./... -coverprofile cover.out
/bin/sh: 1: source: not found
/bin/sh: 1: fetch_envtest_tools: not found
/bin/sh: 1: setup_envtest_env: not found

And since sourcing script which would have set KUBEBUILDER_ASSETS failed, I have the following error as test result:

<*fmt.wrapError | 0xc000223120>: {
           msg: "failed to start the controlplane. retried 5 times: fork/exec /usr/local/kubebuilder/bin/etcd: no such file or directory",
          err: {
            Op: "fork/exec",
            Path: "/usr/local/kubebuilder/bin/etcd",
            Err: 0x2,
           },
}

What versions of software are you using? Specifically, the following are often useful:

• go version: go1.15.10 darwin/amd64
• kubebuilder version: 3.0.0-beta.1
• controller-runtime version: v0.7.2

I've solved my issue with setting the SHELL environment variable to /bin/bash/ for the test target with the following code:

ENVTEST_ASSETS_DIR=$(shell pwd)/bin
+test: SHELL := /bin/bash
test: manifests generate fmt vet
       mkdir -p ${ENVTEST_ASSETS_DIR}
       test -f ${ENVTEST_ASSETS_DIR}/setup-envtest.sh || curl -sSLo ${ENVTEST_ASSETS_DIR}/setup-envtest.sh https://raw.githubusercontent.com/kubernetes-sigs/controller-runtime/v0.7.2/hack/setup-envtest.sh
       source ${ENVTEST_ASSETS_DIR}/setup-envtest.sh; fetch_envtest_tools $(ENVTEST_ASSETS_DIR); setup_envtest_env $(ENVTEST_ASSETS_DIR); go test ./... -coverprofile cover.out

/kind bug

[estroz]

See #1892. I'm going to leave this open so others who encounter this issue see it.

/triage duplicate