Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Scaffolding Makefile using controller-runtime v0.9.1 #2235

Closed
BostjanBozic opened this issue Jun 24, 2021 · 2 comments
Closed

Scaffolding Makefile using controller-runtime v0.9.1 #2235

BostjanBozic opened this issue Jun 24, 2021 · 2 comments
Labels
kind/feature Categorizes issue or PR as related to a new feature.

Comments

@BostjanBozic
Copy link

What do you want to happen?

It would be great if we can adjust scaffolding to use sigs.k8s.io/controller-runtime v0.9.1.

With v0.9.0 new way of setting up environment test has been done. Instead of using .sh script, go module is used now (kubernetes-sigs/controller-runtime#1488). This means that Makefile scaffolding (test target) would have to be adjusted.

I am not sure if there is anything else in scaffolding though that would have to be changed with new controller-runtime version.

Extra Labels

No response
@BostjanBozic BostjanBozic added the kind/feature Categorizes issue or PR as related to a new feature. label Jun 24, 2021
@varshaprasad96
Copy link
Member

@BostjanBozic yes, the go/v3 plugin needs to be bumped to use latest version of controller runtime and 1.21 k8s dependencies. This is in progress, and would be done in #2208

@camilamacedo86
Copy link
Member

it is done. thank you for raise that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@camilamacedo86 @BostjanBozic @varshaprasad96