Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide an option to disable coredns forward plugin to upstream dns server #9497

Closed
liofko opened this issue Nov 16, 2022 · 3 comments · Fixed by #9502
Closed

Provide an option to disable coredns forward plugin to upstream dns server #9497

liofko opened this issue Nov 16, 2022 · 3 comments · Fixed by #9502
Labels
kind/feature Categorizes issue or PR as related to a new feature.

Comments

@liofko
Copy link

liofko commented Nov 16, 2022

What would you like to be added:
I would like to have an option to completely disable the coredns's forward plugin to upstream DNS servers in both coredns and nodelocaldns config files (coredns-config.yml and nodelocaldns-config.yml)

Why is this needed:
In an fully offline environment, without connection to any upstream DNS server (both internally and externally as 8.8.8.8), when both
upstream_dns_servers and /etc/resolv.conf file are empty, the coredns and nodelocaldns are crashing with the following error:
"plugin/forward: no nameservers found"

@liofko liofko added the kind/feature Categorizes issue or PR as related to a new feature. label Nov 16, 2022
@yankay
Copy link
Member

yankay commented Nov 17, 2022

HI @liofko

Thanks for your advice.

@liofko
Copy link
Author

liofko commented Nov 20, 2022

Hi @yankay
Thanks for your response.

#9502 won't add an option to disable upstream dns servers, right ?
It will only verify non-empty resolv.conf during pre-checks.

Thanks
liofko

@yankay
Copy link
Member

yankay commented Nov 21, 2022

Hi @yankay Thanks for your response.

#9502 won't add an option to disable upstream dns servers, right ? It will only verify non-empty resolv.conf during pre-checks.

Thanks liofko

HI @liofko

Yes, you are right. the PR is only to add a check to prevent the coredns crash.

And I think an option is also useful.
If glad to, feel free to provide a PR. :-)

Thank you very much.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants