Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ginkgo v2 flag changes break testing older k8s versions #204

Closed
rifelpet opened this issue Jul 29, 2022 · 3 comments · Fixed by #206
Closed

Ginkgo v2 flag changes break testing older k8s versions #204

rifelpet opened this issue Jul 29, 2022 · 3 comments · Fixed by #206

Comments

@rifelpet
Copy link
Contributor

kOps uses kubetest2 to test all supported k8s versions. The flag changes from upgrading to ginkgo v2 (#200) impact all usage of kubetest2. Because ginkgo was only upgraded to v2 in k/k's master branch, older k8s versions still use ginkgo v1. This inconsistency results in failures to test older k8s versions.

example with k8s 1.22 from kubernetes/kops#14061

	 -------------------------------------------------------------------
	|                                                                   |
	|  Ginkgo timed out waiting for all parallel nodes to report back!  |
	|                                                                   |
	 -------------------------------------------------------------------

 e2e timed out. path: ./_rundir/d40e3fa1-0f35-11ed-80a5-ea2e797f9e54
[1] flag provided but not defined: -ginkgo.flake-attempts
[1] Usage of /home/prow/go/src/k8s.io/kops/_rundir/d40e3fa1-0f35-11ed-80a5-ea2e797f9e54/e2e.test: 
...

Can we make kubetest2's ginkgo flag changes conditional based on the k8s version being tested? Or what is the expected path forward to use the latest kubetest2 while testing older supported k8s versions?

@BenTheElder
Copy link
Member

#201 (comment)

@BenTheElder
Copy link
Member

short term: consider pinning the version you use: #17 (comment)

@rifelpet
Copy link
Contributor Author

rifelpet commented Aug 1, 2022

Confirmed #206 fixed the issue for kops 👍🏻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants