Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not export DefaultOptions is not needed #1100

Closed
mimowo opened this issue Sep 8, 2023 · 1 comment · Fixed by #1121
Closed

Do not export DefaultOptions is not needed #1100

mimowo opened this issue Sep 8, 2023 · 1 comment · Fixed by #1121
Assignees
@lowang-bh
Labels
kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt.

Comments

@mimowo
Copy link
Contributor

mimowo commented Sep 8, 2023

This is a follow up to address: #1069 (comment)

What would you like to be cleaned:

The DefaultOptions is not used externally so does not need to be exported.

Why is this needed:

To improve readability by allowing to deduce about the scope of variables quickly.
@mimowo mimowo added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label Sep 8, 2023
@mimowo mimowo mentioned this issue Sep 8, 2023
Merged
@lowang-bh lowang-bh mentioned this issue Sep 14, 2023
Merged
@lowang-bh
Copy link
Member

/assign

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lowang-bh lowang-bh

Labels
kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Do not export variables that are not externally used dragon-flyings/kueue
2 participants
@mimowo @lowang-bh