Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle Pod overhead added during pod admission #119

Closed
Tracked by #222
alculquicondor opened this issue Mar 15, 2022 · 1 comment · Fixed by #191
Closed
Tracked by #222

Handle Pod overhead added during pod admission #119

alculquicondor opened this issue Mar 15, 2022 · 1 comment · Fixed by #191
Assignees
Labels
kind/feature Categorizes issue or PR as related to a new feature. kind/productionization

Comments

@alculquicondor
Copy link
Contributor

What would you like to be added:

Pod overhead is currently counted for workloads

func podRequests(spec *corev1.PodSpec) Requests {
res := Requests{}
for _, c := range spec.Containers {
res.add(newRequests(c.Resources.Requests))
}
for _, c := range spec.InitContainers {
res.setMax(newRequests(c.Resources.Requests))
}
res.add(newRequests(spec.Overhead))
return res
}

However, the Pod overhead is usually added during Pod creation based on the Runtime class. We should handle this.

Why is this needed:

The calculations might not be accurate, depending on the Runtime class.

@alculquicondor alculquicondor added the kind/feature Categorizes issue or PR as related to a new feature. label Mar 15, 2022
@kerthcet
Copy link
Contributor

/assign

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature. kind/productionization
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants