Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Account for new workload usage in queueUnderNominalInResourcesNeedingPreemption #4104

Open
gabesaba opened this issue Jan 30, 2025 · 0 comments
Open

Account for new workload usage in queueUnderNominalInResourcesNeedingPreemption #4104

gabesaba opened this issue Jan 30, 2025 · 0 comments
Labels
kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt.

Comments

@gabesaba
Copy link
Contributor

What would you like to be cleaned:
As noted #2595 (comment), this function should take into account incoming workload's requests. cq usage + wl requests <= nominal

Why is this needed:
Current check is inaccurate. Also add unit tests to demonstrate faulty current behavior
@gabesaba gabesaba added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label Jan 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@gabesaba