Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to skip schema-validation for values in HelmChartInflationGenerator #5813

Open
2 tasks done
Argelbargel opened this issue Nov 25, 2024 · 1 comment
Open
2 tasks done
Labels
kind/feature Categorizes issue or PR as related to a new feature. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one.

Comments

@Argelbargel
Copy link

Eschewed features

  • This issue is not requesting templating, unstuctured edits, build-time side-effects from args or env vars, or any other eschewed feature.

What would you like to have added?

Add a field skipSchemaValidation to the HelmChartInflationGenerator and pass it as --skip-schema-validation to helm if it's value is true

Why is this needed?

helm enforces schema validation for the values passed to a chart if the chart defines a schema for the expected values. While this feature might be practical in some use-cases it is a problem when using a helm-chart as dependency when the passed values contain properties for other dependencies or the main chart.

Thus helm added the option --skip-schema-validation (helm/helm#11510). Unfortunatly there seems to be no way to pass this flag using the HelmChartInflationGenerator

Can you accomplish the motivating task without this feature, and if so, how?

As there seems to be no way to disable helm's schema-validation globally, i see no (good/easy) way to use such charts with the HelmChartInflationGenerator otherwise.

What other solutions have you considered?

n/a

Anything else we should know?

No response

Feature ownership

  • I am interested in contributing this feature myself! 🎉
@Argelbargel Argelbargel added the kind/feature Categorizes issue or PR as related to a new feature. label Nov 25, 2024
@k8s-ci-robot k8s-ci-robot added the needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. label Nov 25, 2024
@k8s-ci-robot
Copy link
Contributor

This issue is currently awaiting triage.

SIG CLI takes a lead on issue triage for this repo, but any Kubernetes member can accept issues by applying the triage/accepted label.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one.
Projects
None yet
Development

No branches or pull requests

2 participants