Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better error message if replacement is invalid #5814

Open
2 tasks done
guettli opened this issue Nov 25, 2024 · 1 comment
Open
2 tasks done

Better error message if replacement is invalid #5814

guettli opened this issue Nov 25, 2024 · 1 comment
Labels
kind/feature Categorizes issue or PR as related to a new feature. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one.

Comments

@guettli
Copy link
Contributor

guettli commented Nov 25, 2024

Eschewed features

  • This issue is not requesting templating, unstuctured edits, build-time side-effects from args or env vars, or any other eschewed feature.

What would you like to have added?

I get this error message:

Error: failed to generate manifests: failed to run kustomize build for "foo/": failed to build kustomization: replacements must specify a source and at least one target

But it does not show me the filename which contains the invalid replacement.

File:

apiVersion: builtin
kind: ReplacementTransformer
metadata:
  name: certificate-namespace-replacement
replacements:
  - source:
      value: mgt-system
    targets:
      - select:
          apiVersion: cert-manager.io/v1
          kind: Certificate
        fieldPaths:
          - metadata.namespace

Why is this needed?

This is needed, so that I solve the issue faster.

Can you accomplish the motivating task without this feature, and if so, how?

yes, somehow I will find the broken file, but this takes longer.

What other solutions have you considered?

.

Anything else we should know?

No response

Feature ownership

  • I am interested in contributing this feature myself! 🎉
@guettli guettli added the kind/feature Categorizes issue or PR as related to a new feature. label Nov 25, 2024
@k8s-ci-robot k8s-ci-robot added the needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. label Nov 25, 2024
@k8s-ci-robot
Copy link
Contributor

This issue is currently awaiting triage.

SIG CLI takes a lead on issue triage for this repo, but any Kubernetes member can accept issues by applying the triage/accepted label.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one.
Projects
None yet
Development

No branches or pull requests

2 participants