Multi-layer overlays fail to render

[mgoodness]

I have a project that uses 4 layers, each of which uses the previous layer as its base.

overlays/sandbox3.us-east-1

bases:
- ../aws-nonprod

overlays/aws-nonprod

bases:
- ../aws

overlays/aws

bases:
- ../../base

When I run kustomize build overlays/sandbox3.us-east-1 with v1.0.11 I get

Error: loadResMapFromBasesAndResources: SemiResources: loadResMapFromBasesAndResources: couldn't make ldr for ../aws: cycle detected: new root '/Users/mgoodness/dev/cluster-configuration/networkpolicy/overlays/aws' contains previous root '/Users/mgoodness/dev/cluster-configuration/networkpolicy/overlays/aws-nonprod'

This configuration worked with kustomize v1.0.10. I am able to render if I skip an intermediate layer. Other projects that use only 3 layers also render correctly.

[laverya]

My team has run into the same with our Skaffold setup.

[monopole]

lemme look

[bstevenson]

Seeing same issue or very similar issue. Worked in 1.0.10 (only changed the disableHash ---> disableNameSuffixHash between 1.0.10 --> 1.0.11)

Structure:

app/
├── app.yaml
├── config-map.yaml
├── kustomization.yaml
├── overlays
│   └── na3
│       └── dev
│           └── kustomization.yaml
└── secrets.yaml

Base kustomization file:

cat app/kustomization.yaml
namespace: "test"
resources:
- config-map.yaml
- app.yaml
- secrets.yaml
generatorOptions:
  timeoutSeconds: 20
  disableNameSuffixHash: true

Overlay kustomization file:

cat app/overlays/na3/dev/kustomization.yaml
bases:
- ../../../../app
imageTags:
- name: <private_repo>/app
  newTag: 6.5.0

Error: loadResMapFromBasesAndResources: couldn't make ldr for ../../../../app: cycle detected: new root '/Users/xxxxxxx/repos/xxxxxx/kubernetes/base/app' contains previous root '/Users/xxxxxxxx/repos/xxxxxxxxxx/kubernetes/base/app/overlays/na3/dev'

[monopole]

@mgoodness feel free to review #624

@bstevenson As things now stand, the layout you describe is disallowed. We found that allowing an overlay to be a subdirectory of a base makes it too easy to create recursion problems.

The fix is to change from

app
├── kustomization.yaml
└── overlays
    └── na3
        └── dev
            └── kustomization.yaml

to

app
├── base
│   └── kustomization.yaml
└── overlays
    └── na3
        └── dev
            └── kustomization.yaml  #  contains "bases: ../../../base"

FWIW, the top level app dir is a good place for a README.md.