Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No need to create worker statefulsets when size=1 #189

Closed
3 tasks
kerthcet opened this issue Aug 7, 2024 · 1 comment · Fixed by #190
Closed
3 tasks

No need to create worker statefulsets when size=1 #189

kerthcet opened this issue Aug 7, 2024 · 1 comment · Fixed by #190
Labels
kind/feature Categorizes issue or PR as related to a new feature.

Comments

@kerthcet
Copy link
Contributor

kerthcet commented Aug 7, 2024

What would you like to be added:

Once we set the size = 1, if we have 10 replicas, we'll have 10 0-replica statefulsets, there's no need to create these statefulsets.

Why is this needed:

When using lws as single-host workload(size=1), this leads to confusion and additional computations.

cc @ahg-g @liurupeng

Completion requirements:

This enhancement requires the following artifacts:

  • Design doc
  • API change
  • Docs update

The artifacts should be linked in subsequent comments.

@kerthcet kerthcet added the kind/feature Categorizes issue or PR as related to a new feature. label Aug 7, 2024
@ahg-g
Copy link
Contributor

ahg-g commented Aug 7, 2024

sounds good to me

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants