Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unknown argument: --input-pkg-root make: *** [Makefile:97: generate] Error 1 when running make generate #195

Closed
Edwinhr716 opened this issue Aug 15, 2024 · 2 comments · Fixed by #196
Assignees
Labels
kind/bug Categorizes issue or PR as related to a bug.

Comments

@Edwinhr716
Copy link
Contributor

Edwinhr716 commented Aug 15, 2024

What happened: When running make generate I get the following error:

make generate
Makefile-deps.mk:28: warning: overriding recipe for target 'genref'
Makefile-deps.mk:28: warning: ignoring old recipe for target 'genref'
test -s /home/edwinhernandez/go-development/lws/bin/controller-gen && /home/edwinhernandez/go-development/lws/bin/controller-gen --version | grep -q v0.14.0 || \
GOBIN=/home/edwinhernandez/go-development/lws/bin go install sigs.k8s.io/controller-tools/cmd/controller-gen@v0.14.0
go: downloading k8s.io/gengo/v2 v2.0.0-20240228010128-51d4e06bde70
cp -f /home/edwinhernandez/go-development/pkg/mod/k8s.io/code-generator@v0.30.3/generate-groups.sh /home/edwinhernandez/go-development/lws/bin/
cp -f /home/edwinhernandez/go-development/pkg/mod/k8s.io/code-generator@v0.30.3/generate-internal-groups.sh /home/edwinhernandez/go-development/lws/bin/
cp -f /home/edwinhernandez/go-development/pkg/mod/k8s.io/code-generator@v0.30.3/kube_codegen.sh /home/edwinhernandez/go-development/lws/bin/
/home/edwinhernandez/go-development/lws/bin/controller-gen object:headerFile="hack/boilerplate.go.txt" paths="./..."
./hack/update-codegen.sh go /home/edwinhernandez/go-development/lws/bin
unknown argument: --input-pkg-root
make: *** [Makefile:97: generate] Error 1

What you expected to happen:

make generate
Makefile-deps.mk:28: warning: overriding recipe for target 'genref'
Makefile-deps.mk:28: warning: ignoring old recipe for target 'genref'
test -s /home/edwinhernandez/go-development/lws/bin/controller-gen && /home/edwinhernandez/go-development/lws/bin/controller-gen --version | grep -q v0.14.0 || \
GOBIN=/home/edwinhernandez/go-development/lws/bin go install sigs.k8s.io/controller-tools/cmd/controller-gen@v0.14.0
cp -f /home/edwinhernandez/go-development/pkg/mod/k8s.io/code-generator@v0.29.7/generate-groups.sh /home/edwinhernandez/go-development/lws/bin/
cp -f /home/edwinhernandez/go-development/pkg/mod/k8s.io/code-generator@v0.29.7/generate-internal-groups.sh /home/edwinhernandez/go-development/lws/bin/
cp -f /home/edwinhernandez/go-development/pkg/mod/k8s.io/code-generator@v0.29.7/kube_codegen.sh /home/edwinhernandez/go-development/lws/bin/
/home/edwinhernandez/go-development/lws/bin/controller-gen object:headerFile="hack/boilerplate.go.txt" paths="./..."
./hack/update-codegen.sh go /home/edwinhernandez/go-development/lws/bin
go: downloading golang.org/x/tools v0.23.0
go: downloading golang.org/x/sync v0.7.0
go: downloading golang.org/x/mod v0.19.0
Generating applyconfig code for 1 targets
Generating client code for 1 targets
Generating lister code for 1 targets
Generating informer code for 1 targets

How to reproduce it (as minimally and precisely as possible): Run make generate using the current head of the repo

Anything else we need to know?: I was able to run make generate if I rollback the changes made on the following PR #191

Environment:

  • Kubernetes version (use kubectl version):
  • LWS version (use git describe --tags --dirty --always):
  • Cloud provider or hardware configuration:
  • OS (e.g: cat /etc/os-release):
  • Kernel (e.g. uname -a):
  • Install tools:
  • Others:
@Edwinhr716 Edwinhr716 added the kind/bug Categorizes issue or PR as related to a bug. label Aug 15, 2024
@Edwinhr716
Copy link
Contributor Author

@kerthcet can you take a look?

@kerthcet
Copy link
Contributor

Yes, this is because of the upstream update of the shell script IIRC.
/assign

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants