Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve security hygiene and documentation #1437

Open
ricardoapl opened this issue Mar 8, 2024 · 5 comments
Open

Improve security hygiene and documentation #1437

ricardoapl opened this issue Mar 8, 2024 · 5 comments
Assignees
Labels
kind/feature Categorizes issue or PR as related to a new feature. triage/accepted Indicates an issue or PR is ready to be actively worked on.

Comments

@ricardoapl
Copy link
Member

What would you like to be added:

Similar to what was proposed in kubernetes-sigs/prometheus-adapter#638 for prometheus-adapter, I suggest we implement the following for metrics-server:

  • Generating an SBOM automatically when a new release is tagged, so that users have a better understanding of whether or not they're affected by a particular vulnerability
  • Generating SLSA/provenance attestation automatically for each new release, so that users can verify the authenticity and trustworthiness of the build process
  • Initializing VEX feed and generating OpenVEX data on each release, so that users have a better understanding of which vulnerabilities present a genuine risk

We should probably also follow up on CLOMonitor security checks previously configured in cncf/clomonitor#1407:

Why is this needed:

I believe this relates to https://github.com/kubernetes/sig-release/blob/193a3cdf8d73e0888c7f6829eea3716918a5af4a/roadmap.md

/kind feature

@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Mar 8, 2024
@dgrisonnet
Copy link
Member

@ricardoapl you mentioned over on Slack that Manuel had done the CLOMonitor integration. Is there anything more to do?

@ricardoapl
Copy link
Member Author

ricardoapl commented Apr 2, 2024

Yes, I suggest the following based on Security Slam: Kubernetes Lightning Round

Release to Community Infrastructure

Automate Security Documentation

  • Task 3: Ensure SBOMs are Generated by Kubernetes BOM
  • Task 4: Ensure SLSA Attestations are Generated when Possible
  • Task 5: Ensure the Project has a VEX Feed

CLOMonitor: Secure Development Practices

  • Task 7: Set up CLOMonitor Tracking (Add metrics-server to projects cncf/clomonitor#1407)
  • Task 8: Check for Binary Artifacts (no binaries found in the repo)
  • Task 9: Review the Code Review (all changesets reviewed)
  • Task 10: Dangerous Workflow (no dangerous workflow patterns detected)
  • Task 11: Security Insights
  • Task 12: Dependencies Policy
  • Task 13: Dependency update tool (update tool detected, dependabot)
  • Task 15: Token Permissions

@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue as fresh with /remove-lifecycle stale
  • Close this issue with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jul 2, 2024
@ricardoapl
Copy link
Member Author

/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jul 2, 2024
@dashpole
Copy link

dashpole commented Sep 5, 2024

/assign @ricardoapl
/triage accepted

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Sep 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Development

No branches or pull requests

5 participants