Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release v0.6.0 #300

Closed
9 tasks done
marquiz opened this issue Apr 6, 2020 · 16 comments
Closed
9 tasks done

Release v0.6.0 #300

marquiz opened this issue Apr 6, 2020 · 16 comments

Comments

@marquiz
Copy link
Contributor

marquiz commented Apr 6, 2020

Release checklist:

  • All OWNERS must LGTM the release proposal.
  • Update the deployment templates (master, worker-daemonset, worker-job and combined)to use the new tagged container image
  • An OWNER runs git tag -s $VERSION and insert the changelog into the tag description.
  • An OWNER pushes the tag with git push $VERSION (this will also build and push a release container image to quay.io).
  • Update the :latest virtual tag in quay.io to track the last stable (this) release.
  • Write the change log into the Github release info.
  • Add a link to the tagged release in this issue.
  • An announcement email is sent to kubernetes-dev@googlegroups.com with the
    subject [ANNOUNCE] node-feature-discovery $VERSION is released. Add a link to the release announcement here.
  • Close this issue.

Changelog

Major changes

Miscellaneous

Deployment

For complete documentation see the v0.6.0 release

For quick start, you can use the provided template specs to deploy the NFD release image with the default configuration in the default namespace:

export NFD_VERSION=v0.6.0
kubectl apply -f https://raw.githubusercontent.com/kubernetes-sigs/node-feature-discovery/$NFD_VERSION/nfd-master.yaml.template
kubectl apply -f https://raw.githubusercontent.com/kubernetes-sigs/node-feature-discovery/$NFD_VERSION/nfd-worker-daemonset.yaml.template
@marquiz
Copy link
Contributor Author

marquiz commented May 20, 2020

@zvonkok @Ethyling what do you think about cutting a release? I udpated the changelog above.

I already created a PR updating the version tag in documentation and template specs (#310), but, it would be nice to get at least #316 merged before that. We could also consider #307 and #310 (ping @pmundt).

@pmundt
Copy link
Contributor

pmundt commented May 20, 2020

#310 should now be ready to go (pong @marquiz).

@marquiz
Copy link
Contributor Author

marquiz commented May 20, 2020

#310 should now be ready to go

Thanks! Merged. I updated changelog above accordingly.

@zvonkok
Copy link
Contributor

zvonkok commented May 20, 2020

@marquiz So the only one left is #307 as far as I can see all other merged from the above comment.

@marquiz
Copy link
Contributor Author

marquiz commented May 20, 2020

Yes, that's right. I think we can skip #307 even if I consider that as a nice-to-have fix

@marquiz
Copy link
Contributor Author

marquiz commented May 21, 2020

Changelog above updated.

Thanks @Ethyling for all the all the very responsive review work! We got in a lot of cleanups and CI improvements. I think we could merge #317 before closing this as it's virtually lgtm.

Before cutting a release, I also need to (re-)do some manual end-to-end verification because of all the latest changes.

@pmundt
Copy link
Contributor

pmundt commented May 21, 2020

If it's possible to still sneak in #322 this would resolve the only outstanding issue I've run into for multi-arch builds.

@marquiz
Copy link
Contributor Author

marquiz commented May 21, 2020

If it's possible to still sneak in #322

Yeah, sure. That is even such an nonintrusive patch. I really briefly looked at it. Might be good to get another peek (from me or somebody else).

@jjacobelli
Copy link
Contributor

Do you want to merge #313 too?

@marquiz
Copy link
Contributor Author

marquiz commented May 25, 2020

Do you want to merge #313 too?

We can do that but it's not high prio. I'll push a rebased version so you can take a look

@marquiz
Copy link
Contributor Author

marquiz commented May 25, 2020

I did some release testing today and didn't find any issues. So far so good 🤞

What I'd like to check if we would be able to switch over to gcr.io (#177) already on this release.

@marquiz
Copy link
Contributor Author

marquiz commented May 26, 2020

Looks like we still have to wait for that as the k8s.gcr.io vanity domain flip hasn't been completed, yet.

@marquiz
Copy link
Contributor Author

marquiz commented May 26, 2020

...so I think we could cut a release with what we have at the moment. @Ethyling @zvonkok (?)

@jjacobelli
Copy link
Contributor

Yeah I think we are good for this one 😄

@zvonkok
Copy link
Contributor

zvonkok commented May 28, 2020

/lgtm
Just verified that we have the PRs that we need for the upcoming work.

@marquiz
Copy link
Contributor Author

marquiz commented May 28, 2020

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants