Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Honor resource limits for CPU and memory #682

Open
jabbrwcky opened this issue Nov 4, 2024 · 1 comment
Open

Feature: Honor resource limits for CPU and memory #682

jabbrwcky opened this issue Nov 4, 2024 · 1 comment
Labels
needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one.

Comments

@jabbrwcky
Copy link

Hi,

when running the adapter in my cluster I often get OOM-Kills because of a runaway resource consumption.

It would be nice if prometheus-adapter would honor configured resource limits, so it is more stable to operate.

The simplest way would be to use https://github.com/uber-go/automaxprocs for CPU limits and https://github.com/KimMachineGun/automemlimit for memory resource limits.

Depending on how much configurability is required (both default to NOOP if no (cgroup) limits are configured) the integration complexity ranges form two _-imports to adding three flags (enabling each feature + configuring percentage of memory quota used for go process)

I'd be happy to add the required functionality, but I'd first like to see what meets the project requirements.

@k8s-ci-robot
Copy link
Contributor

This issue is currently awaiting triage.

If prometheus-adapter contributors determine this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. label Nov 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one.
Projects
None yet
Development

No branches or pull requests

2 participants