Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Coscheduling] test: need a integration test for PodGroup Status #516

Closed
zwpaper opened this issue Feb 15, 2023 · 3 comments · Fixed by #549
Closed

[Coscheduling] test: need a integration test for PodGroup Status #516

zwpaper opened this issue Feb 15, 2023 · 3 comments · Fixed by #549
Assignees

Comments

@zwpaper
Copy link
Member

zwpaper commented Feb 15, 2023

we have an integration test for coscheduling, https://github.com/kubernetes-sigs/scheduler-plugins/blob/master/test/integration/coscheduling_test.go, but it did not test the PodGroup status.

if PodGroup Status is not functionally working, we can not found the issue

@Huang-Wei
Copy link
Contributor

We didn't invest too much effort in the controller's quality TBH. We can polish the controller code, along with adequate tests once we finish the migration to ctrl-runtime.

@Gekko0114
Copy link
Member

Hi @zwpaper ,
Can I work on this issue if you don't plan to work on it?

@zwpaper
Copy link
Member Author

zwpaper commented Mar 13, 2023

Hi @Gekko0114, feel free to take and work on it!

/assign @Gekko0114

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants